Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#536 closed defect (fixed)

Resample may overwrite past destination buffer (thanks Paweł Kierski)

Reported by: bennylp Owned by: nanang
Priority: normal Milestone: release-0.9.0
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description (last modified by bennylp)

When converting from 8000 to 44100, the SrcUp() function may write past the destination buffers. This was fixed in r287 but for some reason the fix was lost probably when we upgraded libresample to newer version.

Thanks Paweł Kierski for reporting.

Change History (3)

comment:1 Changed 12 years ago by bennylp

  • Description modified (diff)

comment:2 Changed 12 years ago by nanang

  • Resolution set to fixed
  • Status changed from new to closed

In r1968: reapplied r287 (resample may write pass the output buffer), with a bit optimization

comment:3 Changed 12 years ago by nanang

In r1969: fixed bug in SrcUD (missed fix, previously r1968 only fixed SrcUp?()

Note: See TracTickets for help on using tickets.