Opened 12 years ago

Closed 12 years ago

#494 closed enhancement (fixed)

Configuration option to use high quality tone generation

Reported by: bennylp Owned by: nanang
Priority: trivial Milestone: release-0.9.0
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

The tone generator heavily depends on the quality of sine wave generation, and PJMEDIA uses a sine wave emulation which previously thought to give good balance between quality and speed. With this method, speed definitely is much better than using <math.h>, but quality, well turns out not to be perfect.

Norman Franke reported on pjsip list:

Perhaps there should be an option to use a better one, since this one is incompatible with some remote systems. Oddly, it seemed some digits would work, like zero. Nine seemed to be a constant problem, which uses a higher frequency

We should have something like PJMEDIA_USE_HIGH_QUALITY_TONEGEN to activate the tonegen generation using <math.h>, and default should be enabled.

Attachments (1)

ticket494.patch (3.5 KB) - added by nanang 12 years ago.
Enable high quality tone generator by default.

Download all attachments as: .zip

Change History (2)

Changed 12 years ago by nanang

Enable high quality tone generator by default.

comment:1 Changed 12 years ago by bennylp

  • Resolution set to fixed
  • Status changed from new to closed

Committed patch as is in r1859, thanks.

Note: See TracTickets for help on using tickets.