Opened 9 years ago

Closed 9 years ago

#1237 closed defect (fixed)

Incoming SDP reoffer containing secured and unsecured media gets rejected in SRTP mandatory mode

Reported by: nanang Owned by: nanang
Priority: normal Milestone: release-2.0-dev
Component: pjmedia Version: 2.0-dev-branch
Keywords: sipit28 Cc:
Backport to 1.x milestone: Backported:

Description (last modified by nanang)

Scenario:

  1. In SRTP mandatory mode, call established with 2 media: active audio with SRTP enabled and inactive video (port 0).
  2. Remote send re-offer with three SDP media lines: audio with RTP/SAVP+crypto, deactivated video (port 0) with RTP/SAVP without crypto, audio with RTP/AVP without crypto.
  3. We reject the re-INVITE with 488 (actual error code PJMEDIA_SRTP_ESDPREQCRYPTO).

It should not be rejected as the first media in the reoffer is actually acceptable.

Change History (2)

comment:1 Changed 9 years ago by nanang

  • Description modified (diff)
  • Summary changed from SDP parsing, validation, and negotiation issues to Incoming SDP reoffer containing secured and unsecured media gets rejected in SRTP mandatory mode

comment:2 Changed 9 years ago by nanang

  • Resolution set to fixed
  • Status changed from new to closed

(In [3560]) Fix #1237, #1238, #1241:

  • Fixed handling remote re-offer, where SDP media line may be added or removed.
  • Fixed bug in receiving remote offer (initial or subsequent), media channel create sdp must consider acc->cfg.max_audio_cnt setting.
  • Fixed bug media transport is not closed after call disconnected.
  • Fixed assertion in lock_codec after receiving initial answer but no acceptable media (in pjsua level, e.g: SRTP nego failed), now the call will be terminated.
Note: See TracTickets for help on using tickets.