Opened 8 years ago

Closed 8 years ago

#1114 closed defect (fixed)

Wrong bytes_per_frame in stream port info (thanks Thomas Giesel for the report and fix)

Reported by: nanang Owned by: nanang
Priority: normal Milestone: release-1.8
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

Currently, the bytes_per_frame in stream port info contains encoded frame size info, regardless if data flow from/to stream (via get_frame()/put_frame()) is encoded or raw data.

This may cause problem as any pjmedia ports may use bytes_per_frame info, e.g: resample port uses bytes_per_frame info of down stream port to calculate dynamic buffer size, and lesser buffer size may cause buffer overrun.

The original report can be found here.

Change History (1)

comment:1 Changed 8 years ago by nanang

  • Resolution set to fixed
  • Status changed from new to closed

(In [3292]) Fix #1114:

  • Fixed bytes_per_frame calculation in stream port.
  • Fixed sample streamutil.c to use codec info/param for codec bandwidth calculation (was using bytes_per_frame info of stream port).
  • Doc fix for bytes_per_frame field in pjmedia_port_info.
Note: See TracTickets for help on using tickets.