Changeset 4851 for pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app_legacy.c

Timestamp:

May 23, 2014 9:29:09 AM (10 years ago)

Author:

nanang

Message:

Misc (re #1751): Fixed uninitialized config filename in ui_write_settings() in pjsua app (thanks Lars Helgeson for the report).

File:

• pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app_legacy.c (modified) (4 diffs)

pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app_legacy.c

@@ -1614 +1614 @@
 }
 
-static void ui_write_settings()
+static void ui_write_settings(const char *filename)
 {
     char settings[2000];
     int len;
-    char buf[128];
 
     len = write_settings(&app_config, settings, sizeof(settings));
@@ -1627 +1626 @@
         pj_status_t status;
 
-        status = pj_file_open(app_config.pool, buf, PJ_O_WRONLY, &fd);
+        status = pj_file_open(app_config.pool, filename, PJ_O_WRONLY, &fd);
         if (status != PJ_SUCCESS) {
             pjsua_perror(THIS_FILE, "Unable to open file", status);
@@ -1635 +1634 @@
             pj_file_close(fd);
 
-            printf("Settings successfully written to '%s'\n", buf);
+            printf("Settings successfully written to '%s'\n", filename);
         }
     }
@@ -1908 +1907 @@
         case 'f':
             if (simple_input("Enter output filename", buf, sizeof(buf))) {
-                ui_write_settings();
+                ui_write_settings(buf);
             }
             break;