Changeset 2928 for pjproject/trunk/pjnath/src/pjnath-test/stun.c

Timestamp:

Oct 7, 2009 8:38:02 AM (15 years ago)

Author:

bennylp

Message:

More ticket #960: STUN compatibility problem with RFC 3489 servers (in encoding SERVER-NAME or SOFTWARE attribute)

• rollback the previous fix in r2916 since it is broken. It fails various authentication scenarios due to alignment of USERNAME attribute
• this fix only applies old alignment rule to SERVERNAME attribute or when STUN magic is not used in the message
• also disabled test vectors from draft-denis-behave-rfc3489bis-test-vectors-02, it fails with this fix

File:

• pjproject/trunk/pjnath/src/pjnath-test/stun.c (modified) (3 diffs)

pjproject/trunk/pjnath/src/pjnath-test/stun.c

@@ -480 +480 @@
         "",
         &create_msgint1
-    },
+    }
+    /* disabled: see http://trac.pjsip.org/repos/ticket/960
+    ,
     {
         PJ_STUN_BINDING_RESPONSE,
@@ -504 +506 @@
         &create_msgint2
     }
+    */
+
+    /* disabled: see http://trac.pjsip.org/repos/ticket/960
 #if defined(PJ_HAS_IPV6) && PJ_HAS_IPV6!=0
     ,
@@ -543 +548 @@
     }
 #endif
+    */
 };