Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#960 closed defect (fixed)

STUN compatibility problem with RFC 3489 servers (in encoding SERVER-NAME or SOFTWARE attribute)

Reported by: bennylp Owned by: bennylp
Priority: blocker Milestone: release-1.5
Component: pjnath Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

The padding rule difference for string type attributes (notably SOFTWARE or SERVER-NAME attribute) between RFC 3489 and RFC 5389 causes our request to be rejected by RFC 3489 compliant STUN servers. This will cause requests to time out.

Change History (2)

comment:1 Changed 10 years ago by bennylp

  • Resolution set to fixed
  • Status changed from new to closed

In r2916:

  • now always set string attribute's length to 4-bytes aligned.

comment:2 Changed 10 years ago by bennylp

In r2928:

  • rollback the previous fix in r2916 since it is broken. It fails various authentication scenarios due to alignment of USERNAME attribute
  • this fix only applies old alignment rule to SERVERNAME attribute or when STUN magic is not used in the message
  • also disabled test vectors from draft-denis-behave-rfc3489bis-test-vectors-02, it fails with this fix
Note: See TracTickets for help on using tickets.