Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#953 closed defect (fixed)

ICE may find the wrong best candidate (thanks John Ridges for the report)

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-1.5
Component: pjnath Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

Report on http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2009-August/008526.html:

In ice_session.c, and that lines 2317 and 2320 should be reversed (in other words the valid list should be sorted *after* the valid check is updated, or else "new_check" will point to something random).

Change History (2)

comment:1 Changed 10 years ago by bennylp

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r2905

comment:2 Changed 10 years ago by bennylp

In r3022:

  • the sorting process may cause valid checks to point to the wrong candidate pair. This is reproducible by pjnath-test
Note: See TracTickets for help on using tickets.