Ticket #919 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

An iLBC session must use same mode in both directions.

Reported by: nanang Owned by: nanang
Priority: normal Milestone: release-1.4
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

Currently, pjsua will do asymmetric iLBC mode when SDP offer answer specify different iLBC mode.

RFC 3952 Section 5:

   It is important to emphasize the bi-directional character of the
   "mode" parameter - both sides of a bi-directional session MUST use
   the same "mode" value.

   The offer contains the preferred mode of the offerer.  The answerer
   may agree to that mode by including the same mode in the answer, or
   may include a different mode.  The resulting mode used by both
   parties SHALL be the lower of the bandwidth modes in the offer and
   answer.

   That is, an offer of "mode=20" receiving an answer of "mode=30" will
   result in "mode=30" being used by both participants.  Similarly, an
   offer of "mode=30" and an answer of "mode=20" will result in
   "mode=30" being used by both participants.

Change History

comment:1 Changed 9 years ago by nanang

In r2834:

  • Added default ilbc mode into codec passthrough setting.
  • Added iLBC mode 'negotiation' in iLBC codec_open().
  • Updated stream_create() to prioritize codec_open(), that may update the codec params, over stream initializations involving codec params.

comment:2 Changed 9 years ago by nanang

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.