Ticket #794 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Bug with generating SDP version in origin line (thanks Joel Dodson for the report)

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-1.2
Component: pjsip Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description (last modified by bennylp) (diff)

RFC 3264 mandates that subsequent SDP offer must have version number in SDP origin line incremented by one. This currently is done in PJSUA-LIB, with the update_sdp_version() function.

Upon checking the source codes, turns out this should have been done by the SDP negotiator, hence the update_sdp_version() shouldn't be necessary. Further checking reveals that there was a bug in the INVITE session (sip_inv.c), which doesn't use the correct SDP offer as "fixed" by the negotiator, hence the INVITE session does not produce the correct SDP.

The corresponding ticket for 1.0 branch is #795

Change History

comment:1 Changed 10 years ago by bennylp

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r2643:

  • the INVITE session now correctly uses the SDP offer "fixed" by the negotiator, hence it will have the correct origin fields.
  • removed update_sdp_version() from PJSUA-LIB
  • the negotiator now also fixes the session ID of subsequent answer so that it's identical to the previous SDP

comment:2 Changed 10 years ago by bennylp

In r2665:

  • fixed compilation error on Symbian

comment:3 Changed 10 years ago by bennylp

  • Description modified (diff)

comment:4 Changed 10 years ago by bennylp

  • Description modified (diff)
Note: See TracTickets for help on using tickets.