Opened 11 years ago

Closed 11 years ago

#747 closed defect (fixed)

Bugs in parsing SIP torture messages (RFC 4475) (thanks Norma Steveley for the report)

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-1.1
Component: pjsip Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description (last modified by bennylp)

Problems were reported in handling these torture messages.

The corresponding ticket for 1.0 branch is ticket #748

Change History (4)

comment:1 follow-up: Changed 11 years ago by bennylp

  • Description modified (diff)

Initial fixes:

  • SIP version components may be separated by whitespaces (e.g. "SIP / 2.0")
  • parsing of mangled header when for unknown/generic header
  • Via parameters were parsed with paramchar rather than token
  • handling NULL character inside quoted string

Some torture messages have been added in the Python test.

comment:2 Changed 11 years ago by bennylp

  • Summary changed from Bugs in parsing of SIP torture messages (RFC 4475) (thanks Norma Steveley for the report) to Bugs in parsing SIP torture messages (RFC 4475) (thanks Norma Steveley for the report)

comment:3 in reply to: ↑ 1 Changed 11 years ago by bennylp

Replying to bennylp:

Initial fixes:

  • SIP version components may be separated by whitespaces (e.g. "SIP / 2.0")
  • parsing of mangled header when for unknown/generic header
  • Via parameters were parsed with paramchar rather than token
  • handling NULL character inside quoted string

Some torture messages have been added in the Python test.

This was checked in in r2505

comment:4 Changed 11 years ago by bennylp

  • Resolution set to fixed
  • Status changed from new to closed

In r2522:

  • the previous fix in r2505 causes parsing IPv6 address in Via to fail.
  • Also added some torture messages in the SIP message test vectors.
Note: See TracTickets for help on using tickets.