Opened 11 years ago

Closed 9 years ago

#668 closed enhancement (fixed)

Omit media attributes when rejecting SDP media lines

Reported by: bennylp Owned by: nanang
Priority: minor Milestone: release-1.7
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description (last modified by nanang)

Currently when we reject a media line in SDP offer, we copy the media descriptor from the offer in the answer and set the port to zero.

This works fine. However this may create some confusions when troubleshooting a problem, therefore using simpler structure of media descriptor (m= line with port 0 without any 'a=' lines) may be preferable and perhaps even more efficient.

Change History (4)

comment:1 Changed 10 years ago by bennylp

  • Milestone changed from release-1.0.1 to Known-Issues

Non urgent, moving to known-issues.

comment:2 Changed 9 years ago by nanang

  • Milestone changed from Known-Issues-and-Ideas to release-1.7

comment:3 Changed 9 years ago by nanang

(In [3198]) Re #668:

  • Fixed process_answer() of SDP negotiation, when no common format in a media, instead of returning error, it should just deactivate the media (offer & answer) and continue negotiating next media.
  • Generalized the way of deactivating media: set port to 0 and remove all attributes.
  • Added new API pjmedia_sdp_media_clone_deactivate() to clone media and deactivate the newly cloned media.
  • Updated PJMEDIA SDP negotiation test.

comment:4 Changed 9 years ago by nanang

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from Use empty media descriptor when rejecting SDP media lines to Omit media attributes when rejecting SDP media lines
Note: See TracTickets for help on using tickets.