Ticket #526 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Pjsua crash after wav player destroyed inside the eof callback (thanks Tanguy Floc'h)

Reported by: nanang Owned by: nanang
Priority: normal Milestone: release-0.9.0
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2008-April/002513.html after destroyed, wav player port get_frame() returns PJ_SUCCESS to conference, so the conference continue accessing the wav player port.

Attachments

ticket526.patch (4.8 KB) - added by nanang 10 years ago.
ticket526.2.patch (1.1 KB) - added by nanang 10 years ago.
Fixed buggy patch 'ticket526.patch': posibility of accessing port after wav player port destroyed

Change History

Changed 10 years ago by nanang

comment:1 Changed 10 years ago by nanang

In ticket526.patch contains major changes on wav player:

  • On EOF, fill_buffer() NO_LOOP will pad the buffer with zero, for LOOP mode it will rewind the file and fill the end of buffer with the the beginning of file (smooth rewinding).
  • Added new field eofpos to mark the end of file position in the buffer, this field only set when eof is set, otherwise it must be NULL.
  • EOF callback is not called before/at the EOF frame anymore, it is called in the first next get_frame() after the EOF frame returned.

comment:2 Changed 10 years ago by bennylp

  • Status changed from new to closed
  • Resolution set to fixed

Committed ticket526.patch in r1927

Changed 10 years ago by nanang

Fixed buggy patch 'ticket526.patch': posibility of accessing port after wav player port destroyed

comment:3 Changed 10 years ago by bennylp

Committed ticket526.2.patch in r1934

Note: See TracTickets for help on using tickets.