Ticket #478 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Handle duplicated/misordered incoming DTMF packets

Reported by: nanang Owned by: nanang
Priority: normal Milestone: release-0.9.0
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description (last modified by bennylp) (diff)

The incoming RFC 2833 DTMF handler does not handle the case where RTP packets arrive out of order. In this case, the packets may cause stream.c to detect them as multiple DTMF events.

Attachments

dtmf.patch (3.1 KB) - added by nanang 10 years ago.

Change History

Changed 10 years ago by nanang

comment:1 Changed 10 years ago by nanang

Attachment dtmf.patch:

  • Added new API pjmedia_rtp_session_update2() which behaves like pjmedia_rtp_session_update() with additional option to validate payload type
  • Changed in stream.c:
    • replaced pjmedia_rtp_session_update() with pjmedia_rtp_session_update2(), so the RTP session validation will avoid payload type checking when received PT == DTMF event PT
    • moved handle_incoming_dtmf() from before to after pjmedia_rtp_session_update2()

comment:2 Changed 10 years ago by bennylp

  • Status changed from new to closed
  • Resolution set to fixed
  • Description modified (diff)

Committed in r1798 with some modification, thanks.

Note: See TracTickets for help on using tickets.