Ticket #447 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

WAV player cuts last data from the WAV file

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-0.9.0
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

When the WAV player (pjmedia_wav_player_port) is not configured to playback in a loop, it will ignore the last portion of the WAV file if the WAV file size is not aligned to the WAV port's buffer size.

Change History

comment:1 Changed 10 years ago by bennylp

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r1683

comment:2 Changed 10 years ago by bennylp

Is now really fixed in r1685 :)

comment:3 Changed 10 years ago by bennylp

In r1690:

  • the WAV player, once it returns non-PJ_SUCCESS (because of EOF) should consistently return non-PJ_SUCCESS on subsequent get_frame() calls.
  • while we're at it, renamed the (private) WAV player struct name from struct file_port to struct file_reader_port since the same naming as the WAV writer port confuses Visual Studio.
Note: See TracTickets for help on using tickets.