Ticket #43 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

Echo suppressor definition doesn't match the declaration

Reported by: bennylp Owned by: bennylp
Priority: minor Milestone: release-0.5.10
Component: pjmedia Version: 0.5.9
Keywords: echo canceller suppressor Cc:
Backport to 1.x milestone: Backported:

Description (last modified by bennylp) (diff)

the declaration of fun echo_supp_create in file
pjproject-0.5.9\pjmedia\src\pjmedia\echo_suppress.c
has only 6 parameters;
 
PJ_DECL(pj_status_t) echo_supp_create(pj_pool_t *pool,
          unsigned clock_rate,
          unsigned samples_per_frame,
          unsigned tail_ms,
          unsigned options,
          void **p_state );
 
 
However, there are 7 parameters in the declaration in file
pjproject-0.5.9\pjmedia\src\pjmedia\echo_common.c
 
PJ_DECL(pj_status_t) echo_supp_create(pj_pool_t *pool,
          unsigned clock_rate,
          unsigned samples_per_frame,
          unsigned tail_ms,
          unsigned latency_ms,            // not appear in echo_suppress.c
          unsigned options,
          void **p_state );
 
No error appear when compling and linking, but not run correctly;

Change History

comment:1 Changed 12 years ago by bennylp

  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 12 years ago by bennylp

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in r855

Note: See TracTickets for help on using tickets.