Ticket #359 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Wrong Via branch generation in proxy causing the same branch value to be generated for RFC 2543 clients (thanks Helmut Wolf)

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-0.8.0
Component: pjsip Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description

In pjsip_calculate_branch_id() function in sip_util_proxy.c:335, the branch parameter for outgoing request is generated by calculating MD5 hash of the branch parameter of the incoming request. But unfortunately, the user agent being RTC, it does not conform to RFC 3261, and it leaves the branch parameter empty, causing the branch generation to always produce the same value.

Change History

comment:1 Changed 10 years ago by bennylp

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r1411.

While we're at it, also change the IP interface enumeration (see proxy.h) to make use of the new IP helper API.

Note: See TracTickets for help on using tickets.