Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2252 closed defect (fixed)

Fix Darwin video issue if supplied image height is different from the resolution

Reported by: ming Owned by: ming
Priority: normal Milestone: release-2.10
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no

Description

For certain resolution, the supplied image height may not match the requested resolution. For example, 352x288 video may have image height of only 264. So we need to pad the image with black area at the bottom.

Also fix deprecation:

../src/pjmedia-videodev/darwin_dev.m:320:30: warning: 'devices' is deprecated: first deprecated in macOS
      10.15 - Use AVCaptureDeviceDiscoverySession instead. [-Wdeprecated-declarations]
        dev_list = [AVCaptureDevice devices];

Change History (2)

comment:1 Changed 4 years ago by ming

  • Owner set to ming
  • Resolution set to fixed
  • Status changed from new to closed

In 6109:

Fixed #2252: Fix Darwin video issue if supplied image height is different from the resolution

comment:2 Changed 4 years ago by ming

In 6113:

Re #2252: Fixed failed pjmedia-test, due to unsupported conversion format.

Note: See TracTickets for help on using tickets.