Ticket #2171 (closed enhancement: fixed)

Opened 5 weeks ago

Last modified 5 weeks ago

Apply returned frame quality filter in OpenH264 decoder

Reported by: nanang Owned by: nanang
Priority: normal Milestone: release-2.9
Component: pjmedia Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no

Description

The OpenH264 decoder may return non-dsErrorFree and still produce a frame usually with some noise. This ticket will filter the frame quality by inspecting the return code of the decoder, i.e: drop the frame if some specific error codes are returned (dsRefLost dsNoParamSets, dsDepLayerLost).

Change History

comment:1 Changed 5 weeks ago by nanang

  • Status changed from new to closed
  • Resolution set to fixed

In 5925:

Close #2171:

  • Apply returned frame quality filter in OpenH264 decoder (drop the frame if decoder returns dsRefLost dsNoParamSets, dsDepLayerLost).
  • Only publish keyframe missing event when decoder returns non-dsErrorFree (was always publishing the event when no frame is returned, while decoder may return dsErrorFree and no frame returned, e.g: when decoding parameter sets).
  • Added a bit more logs for debugging.
Note: See TracTickets for help on using tickets.