Opened 6 years ago

Closed 5 years ago

#2147 closed defect (fixed)

Miscellaneous fixes

Reported by: ming Owned by: bennylp
Priority: normal Milestone: release-2.9
Component: common Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no

Description

Miscellaneous updates and fixes

Change History (43)

comment:1 Changed 6 years ago by ming

In 5882:

Re #2147 (misc): Fix incorrect call state info on incoming call in PJSUA2
In PJSUA2, due to ticket #1916, on_incoming_call() can be called earlier, during on_create_media_transport().

At this time, call->inv->state is still INV_STATE_NULL (instead of INV_STATE_INCOMING).

This patch only fixes the call info, but doesn't change the invite state itself.

comment:2 Changed 6 years ago by ming

In 5890:

Re #2147 (misc): Add assertion in pjmedia_port_info_init() to prevent division by zero.

comment:3 Changed 6 years ago by ming

In 5891:

Re #2147 (misc): Fixed build error of undefined reference to `pjmedia_srtp_enum_crypto' if PJMEDIA_HAS_SRTP is disabled.

Thanks to Alexei Gradinari for the patch

comment:4 Changed 6 years ago by riza

In 5894:

Re #2147 (misc): Call pj_bzero() to frame_out to avoid undefined value for
bit_info. Thanks to Sai Krishna for the report.

comment:5 Changed 6 years ago by ming

In 5895:

Re #2147 (misc): Change Android libpjsua2.so target directory according to the target architecture

comment:6 Changed 6 years ago by ming

In 5900:

Re #2147 (misc): Fixed account modification lock codec setting

comment:7 Changed 5 years ago by nanang

In 5901:

Misc (re #2147): Assertion in pj_sockaddr_cp() when pjmedia_transport_attach() is called with rem_rtcp zero initialized (thanks Lauri Vänskä for the report).

comment:8 Changed 5 years ago by ming

In 5902:

Re #2147 (misc): Removed null video device declaration, which has no implementation

comment:9 Changed 5 years ago by ming

In 5905:

Re #2147 (misc): Fixed assertion in streamutil sample for not creating event manager

comment:10 Changed 5 years ago by ming

In 5906:

Re #2147 (misc): Put back the printing of contact_rewrite_method, which is missing due to r5833

comment:11 Changed 5 years ago by ming

In 5908:

Re #2147 (misc): Add pjmedia_transport_media_stop() to streamutil sample app, for good practice since we now require media transport to be started since #2097

comment:12 Changed 5 years ago by nanang

In 5910:

Misc (re #2147): pjmedia_transport_media_stop() should not be called before pjmedia_stream_destroy(), otherwise RTCP BYE, DTMF 'End' flag, etc cannot be sent (thanks Lauri Vänskä for the report).

comment:13 Changed 5 years ago by nanang

In 5914:

Misc (re #2147): Invalid media direction (dir=NONE) when receiving first video event PJMEDIA_EVENT_FMT_CHANGED (thanks Giorgio Alfarano for the report).

comment:14 Changed 5 years ago by nanang

In 5915:

Misc (re #2147): Removed 'experimental' word for Speex resampling.

comment:15 Changed 5 years ago by ming

In 5916:

Re #2147 (misc): Fixed incorrect typecast in Speex resampler. Thanks to Sebastian Marek for the patch.

comment:16 Changed 5 years ago by riza

In 5924:

Re #2147 (misc): Include unicode_win32.c on the build configuration for windows (mingw). Without it, the build will fail when enabling PJMEDIA_WMME_DEV_USE_MMDEVICE_API. Thanks to Niclas Larsson for the report.

comment:17 Changed 5 years ago by ming

In 5926:

Re #2147 (misc): set wholeMsg string of SipTxData? to the whole message instead of the whole buffer.

Thanks to Michael Loeffler for the patch.

comment:18 Changed 5 years ago by nanang

In 5937:

Re #2147: Added logging and explicit SIP error code for assertions in SIP message verification.

comment:19 Changed 5 years ago by ming

In 5942:

Re #2147 (misc): Fixed assertion in simpleua sample for not creating event manager.
Also add support for VideoToolbox? codec.

comment:20 Changed 5 years ago by ming

In 5943:

Re #2147 (misc): missed VideoToolbox deinit in r5942

comment:21 Changed 5 years ago by ming

In 5946:

Re #2147 (misc): Contact params update when modifying account

The current contact params updates are not applied when calling pjsua_call_modify(). Updating contact header can be quite complicated so a simpler workaround is to trigger account registration first (the same solution is used to update force_contact).

Thanks to Lars Olsson for the report.

comment:22 Changed 5 years ago by nanang

In 5950:

Misc (re #2147): Updated SSL socket test to include host part in HTTPS request URI, otherwise most likely it will get 400 response.

comment:23 Changed 5 years ago by nanang

In 5952:

Misc (re #2147): Updated SVN property svn:eol-style to native for Java sample app (avoid rejection in merging patch from Linux on Windows).

comment:24 Changed 5 years ago by nanang

In 5956:

Misc (re #2147): Add info and checks about Extra Audio Device supporting mono channel only.

comment:25 Changed 5 years ago by riza

In 5963:

Misc (re #2147): Enable to change SIP outbound instance id when modifying account.
Thanks to Jure Erznožnik for the report.

comment:26 Changed 5 years ago by riza

In 5964:

Misc (re #2147): Add lock to prevent race condition when accessing media list.
Thanks to Niclas Larsson for the report.

comment:27 Changed 5 years ago by nanang

In 5965:

Misc (re #2147): When tracing is enabled, print ALSA error message when opening device failed in device enumeration.

comment:28 Changed 5 years ago by riza

In 5974:

Misc (re #2147): Allow application exceptions to be enriched with Error specific information on CSharp binding. Thanks to Jeremy Franzen for the suggestion.

comment:29 Changed 5 years ago by riza

In 6001:

Re #2147 (misc): Avoid swig error caused by pjsua_snd_dev_id enum definition.

comment:30 Changed 5 years ago by riza

In 6009:

Re #2147 (misc): Fix various compilation warnings on VS2015.

comment:31 Changed 5 years ago by nanang

In 6010:

Misc (re #2147): Fixed various build warnings (when building for Android).

comment:32 Changed 5 years ago by nanang

In 6011:

Misc (re #2147): Fix Android pjsua2 sample app: call state text & call button text in call activity not updated accordingly.

comment:33 Changed 5 years ago by nanang

In 6012:

Misc (re #2147): Updated Android pjsua2 sample app: enable SRTP optional mode without requiring SIP TLS transport.

comment:34 Changed 5 years ago by ming

In 6013:

Re #2147 (misc): Fixed assertion in pjmedia test if video is disabled

comment:35 Changed 5 years ago by nanang

In 6019:

Misc (re #2147): Fixed configure-android script failure to parse NDK version on MacOSX.

comment:36 Changed 5 years ago by nanang

In 6020:

Misc (re #2147): Fixed compile warnings due to unused var/function.

comment:37 Changed 5 years ago by riza

In 6021:

Re #2147 (misc): Fix failed pjsip-test (transport_loop_test) caused by r6002.

comment:38 Changed 5 years ago by nanang

In 6022:

Misc (re #2147): Fixed warnings in SSL socket: redefinition of typedef 'pj_ssl_sock_t' and unused 'get_pem'.

comment:39 Changed 5 years ago by nanang

In 6023:

Misc (re #2147): Updated automated test configs.

comment:40 Changed 5 years ago by nanang

In 6026:

Misc (re #2147): Fixed compile warnings "dynamic exception specifications are deprecated in C++11".

comment:41 Changed 5 years ago by ming

In 6027:

Re #2147 (misc): Suppressed warnings of unused function and misused comma

comment:42 Changed 5 years ago by ming

In 6028:

Re #2147 (misc): Suppressed various warnings from XCode (iOS)

  • this function declaration is not a prototype, and some typecasts

comment:43 Changed 5 years ago by nanang

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.