Ticket #2059 (closed defect: fixed)

Opened 12 months ago

Last modified 7 weeks ago

Miscellaneous fixes

Reported by: ming Owned by: bennylp
Priority: normal Milestone: release-2.8
Component: common Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no

Description

Miscellaneous updates and fixes

Change History

comment:1 Changed 12 months ago by ming

In 5688:

Re #2059 (misc): Fixed possible function name clash with md5 due to non-static function.

Thanks to Luca Ceseroli for the report.

comment:2 Changed 12 months ago by ming

In 5691:

Re #2059 (misc): Fixed potential buffer underflow when reading config file.

comment:3 Changed 11 months ago by riza

In 5696:

Re #2059 (misc): Set conference's port rx_level to 0 when get frames from the
port is skipped. Thanks to Kal Conley for the original patch.

comment:4 Changed 11 months ago by ming

In 5705:

Re #2059 (misc): Fixed ffmpeg H264 unpacketization error due to uninitialized unpack_nal_start

comment:5 Changed 10 months ago by riza

In 5718:

Re #2059 (misc): Update account tp_type when transport_id is changed on pjsua_acc_modify().
Thanks to Oded Arbel for the report.

comment:6 Changed 10 months ago by nanang

In 5719:

Misc (re #2059): Configurable number of socket options (PJ_MAX_SOCKOPT_PARAMS macro).

comment:7 Changed 10 months ago by ming

In 5722:

Re #2059 (misc): sudo make uninstall: Remove ignored failures

Thanks to Alexander Traud for the patch.

comment:8 Changed 10 months ago by ming

In 5723:

Re #2059 (misc): Fixed build error when PJSIP_HAS_RESOLVER==0

comment:9 Changed 9 months ago by riza

In 5729:

Re #2059 (misc): Use PJSIP_MAX_URL_SIZE to print remote info (URL) instead of
hard-coded.

comment:10 Changed 8 months ago by nanang

In r5738:

  • Updated Android & Java app samples to avoid call instance deletion in the library callback context (thanks Kai Ludwig for the feedbacks).

comment:11 Changed 7 months ago by nanang

In 5754:

Re #2059: Fixed assertion in JSON name verification due to NULL string pointer passed to string::compare() in reading array node.

comment:12 Changed 7 months ago by ming

In 5756:

Re #2059: Allow multiple codecs in SDP answer when creating SDP neg with remote offer
Thanks to Alexey Ermoshin for the patch.

comment:13 Changed 7 months ago by ming

In 5757:

Re #2059: Fixed the ordering of CXXFLAGS to prevent build issue on Android, such as below:

In file included from /android-ndk-r15c/platforms/android-15/arch-arm/usr/include/linux/posix_types.h:41:0,

from /android-ndk-r15c/platforms/android-15/arch-arm/usr/include/sys/types.h:37,
from /android-ndk-r15c/platforms/android-15/arch-arm/usr/include/stdio.h:50,
from ../../pjlib/include/pj/compat/string.h:39,
from ../../pjlib/include/pj/string.h:29,
from ../include/pjmedia/frame.h:28,
from ../include/pjmedia/port.h:30,
from ../include/pjmedia/codec.h:29,
from ../include/pjmedia-codec/types.h:29,
from ../include/pjmedia-codec/openh264.h:22,
from ../src/pjmedia-codec/openh264.cpp:19:

/android-ndk-r15c/sysroot/usr/include/arm-linux-androideabi/asm/posix_types.h:33:37: fatal error: asm-generic/posix_types.h: No such file or directory

#include <asm-generic/posix_types.h>

comment:14 Changed 7 months ago by riza

In 5760:

Re #2059 (misc): Add swig_java_pjsua2 project files to build pjsua2 java binding using Visual Studio 2015.

comment:15 Changed 7 months ago by riza

In 5761:

Re #2059 (misc): Don't include test app (exe) when building for Android.

comment:16 Changed 7 months ago by ming

In 5763:

Re #2059 (misc): Remove -Wunused-but-set-variable in Python SIP module.

Thanks to Alexander Traud for the patch.
Note that the patch is a contribution and the module itself has been deprecated and will no longer be maintained (https://trac.pjsip.org/repos/wiki/Python_SIP/Build_Install).

comment:17 Changed 7 months ago by ming

In 5764:

Re #2059 (misc): Fixed incorrect assertion in pjmedia stream
Thanks to Vyacheslav Yamont for the report.

comment:18 Changed 7 months ago by ming

In 5767:

Re #2059 (misc): Replace the warning text so it won't conflict with C compiler warning message.

comment:19 Changed 7 months ago by ming

In 5770:

Re #2059 (misc): Removed warning of unused variable

comment:20 Changed 7 months ago by ming

In 5771:

Re #2059 (misc): Fixed "warnings: deleting object of polymorphic class type 'Base' which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]"

comment:21 Changed 7 months ago by ming

In 5772:

Re #2059 (misc): Remove warning of unused functions if no audio codecs is enabled

comment:22 Changed 7 months ago by ming

In 5773:

Re #2059 (misc): Comment unused const to prevent compiler warning

comment:23 Changed 7 months ago by ming

In 5776:

Re #2059 (misc): Replace the warning text so it won't conflict with C compiler warning message.
Also revert accidental local modification caused by r5767.

comment:24 Changed 7 months ago by ming

In 5777:

Re #2059 (misc):

  • Allow USE_PYTHON3 to be obtained from environment variable.
  • Change PYTHON_EXE. Reasons:
  • The platform Arch Linux defaults to Python 3 already. Therefore, when /usr/bin/python is called, it is not Python 2.7 but Python 3.6.
  • The platform NetBSD and Gentoo Linux does not offer /usr/bin/python3 but only /usr/bin/python3.6.

Thanks to Alexander Traud for the patch.

comment:25 Changed 7 months ago by riza

In 5779:

Re #2059 (misc): Fix some warnings related to use of external Portaudio.
Thanks to Alexander Traud for the report and patch.

comment:26 Changed 6 months ago by nanang

In 5789:

Misc (re #2059): Frame timestamp not set in get_frame_from_buffer() (thanks Giorgio Alfarano for the report).

comment:27 Changed 5 months ago by ming

In 5791:

Re #2059 (misc): Related to #2031. Add compile-time config for L16 48KHz.

comment:28 Changed 5 months ago by riza

In 5796:

Re #2059 (misc): Define missing CPPFLAGS in the aconfigure. Thanks to Alexander
Traud for the patch.

comment:29 Changed 5 months ago by riza

In 5797:

Re #2059 (misc):

  • Fix warning when using LibreSSL.
  • Fix error build when using OpenSSL with './config no-dh' option.
  • Fix error build when using OpenSSL with './config no-deprecated' option.
  • Modification to r5787.

Thanks to Alexander Traud for the patch.

comment:30 Changed 5 months ago by riza

In 5802:

Re #2059 (misc): Don't build swig_java_pjsua2 project on VS2015 by default.

comment:31 Changed 4 months ago by riza

In 5804:

Re #2059 (misc): Patch to build Arch Linux on ARMv7 (e.g: Raspberry Pi).
Thanks to Attila Bogár for the patch.

comment:32 Changed 4 months ago by nanang

In 5808:

Misc (re #2059): Fixed pjsua.py: inconsistent use of tabs and spaces in indentation (thanks Alexander Traud for the patch).

comment:33 Changed 4 months ago by nanang

In 5809:

Misc (re #2059): Removed double space between 'digest' and 'realm=' digest challenge, reported that an old device got problem with it (thanks Martin Gross for the report and the patch).

comment:34 Changed 4 months ago by riza

In 5811:

Re #2059 (misc): Fixed some error on transport_srtp.c after #2097 + #2096.

  • Fixed nullptr exception, because opt pointer might not be set.
  • Remove assertion to check pool and sdp in pjmedia_transport_media_start().

Thanks to Ciro Ferraiuolo for the report.

comment:35 Changed 4 months ago by nanang

In 5813:

Misc (re #2059): Fixed various compile warnings on GCC 8.1 (thanks Alexander Traud for the report).

comment:36 Changed 4 months ago by nanang

In 5814:

Misc (re #2059): Updated configure script to:

  • make sure that C++ compiler is available, and
  • disable ALSA when ALSA development library is not found.

Thanks Alexander Traud for the feedbacks.

comment:37 Changed 4 months ago by nanang

In 5815:

Misc (re #2059): Fixed compile error on MinGW "Including <winsock2.h> after <winsock.h> is unsupported" (thanks Thibault Groisil for the report).

comment:38 Changed 4 months ago by ming

In 5817:

Re #2059 (misc): Add missing fields when exporting UaConfig? to pjsua_config.
Thanks to Imad Khazali for the report.

comment:39 Changed 4 months ago by ming

In 5818:

Re #2059 (misc): Fixed typo in json.c (should be semicolon instead of comma).

Thanks to Sebastian Marek for the report.

comment:40 Changed 4 months ago by ming

In 5819:

Re #2059 (misc): Link AVFoundation framework for iOS build since it's required for using AVAudioSession.
Thanks to Sebastian Marek for the report.

comment:41 Changed 3 months ago by ming

In 5846:

Re #2059 (misc): List ALSA audio device even if it fails to open

If an ALSA audio device cannot be opened for recording and playback, it may mean that they are temporarily busy (such as currently being used by another app), so we should still list it.

Thanks to Tobias Schneider for the patch.

comment:42 Changed 2 months ago by nanang

In 5856:

Misc (re #2059): False error/exception returned by IP change Endpoint::handleIpChange() on Android, it returns error "Address already in use" immediately while a retry attempt is scheduled (i.e: param.restartLisDelay is set to non-zero). Thanks Christian Scheid for the report.

comment:43 Changed 2 months ago by nanang

In 5863:

Misc (re #2059): Fixed crash in pjsua2 sample app (perhaps due to access to invalid MyCall? instance).

comment:44 Changed 7 weeks ago by ming

In 5873:

Re #2059 (misc): Add log for error info when Darwin capture session fails to start running or encounters an error during runtime.

comment:45 Changed 7 weeks ago by ming

In 5874:

Re #2059 (misc): re r5873, add more comment in the code.

comment:46 Changed 7 weeks ago by riza

In 5877:

Re #2059 (misc): Add local RTP/RTCP address information to MediaTransportInfo?.

comment:47 Changed 7 weeks ago by riza

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.