Ticket #202 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

Fix error when telephone-event is set as the first format in SDP (thanks Chris Hamilton)

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-0.5.10.3
Component: pjmedia Version: 0.5.10.2
Keywords: Cc:
Backport to 1.x milestone: Backported:

Description (last modified by bennylp) (diff)

Some client (Gnome ekiga 2.0.3) sends SDP with telephone-event as the first format in SDP m= line, and this causes pjmedia to raise assertion error in pjmedia_stream_info_from_sdp in pjmedia/session.c:

pj_assert(PJMEDIA_RTP_PT_TELEPHONE_EVENTS==0 ||
          pt != PJMEDIA_RTP_PT_TELEPHONE_EVENTS);.

Change History

comment:1 Changed 12 years ago by bennylp

  • Status changed from new to closed
  • Resolution set to fixed
  • Description modified (diff)
  • Summary changed from Fix telephone-event order in SDP (thanks Chris Hamilton) to Fix error when telephone-event is set as the first format in SDP (thanks Chris Hamilton)

Fixed in r1107:

  • pjmedia_stream_info_from_sdp() function should find the first non-telephone-event codec in the format list rather than just relying on fmt[0].
  • while we're at it, fix assert/crash error in pjsua-lib when application is answering the call with 200 but the media failed to start (e.g. when the offer doesn't contain any codec (i.e. only telephone-event)).

Thanks Chris Hamilton <chamilton .at. cs.dal.ca> for the patch.

Note: See TracTickets for help on using tickets.