Ticket #1984 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Remove the implementation of PJ_HASH_USE_OWN_TOLOWER

Reported by: ming Owned by: bennylp
Priority: normal Milestone: release-2.6
Component: pjlib Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no


Currently PJ_HASH_USE_OWN_TOLOWER is only used in pj_hash_calc_tolower(). However, it could cause hash key mismatch (such as when trying to find a SIP transaction key) since find_entry() doesn't seem to take into account of this and try to find key based on the calculation of not using own tolower().

The proposed solution would be to remove PJ_HASH_USE_OWN_TOLOWER since it doesn't offer much efficiency improvement and the implementation only assumes that the string is alphanumeric.

Thanks to Richard Mudgett for the report.

Change History

comment:1 Changed 2 years ago by ming

  • Status changed from new to closed
  • Resolution set to fixed

In 5494:

Fixed #1984: Remove the implementation of PJ_HASH_USE_OWN_TOLOWER

Note: See TracTickets for help on using tickets.