Opened 6 years ago

Closed 6 years ago

#1683 closed defect (fixed)

Fixes for via_rewrite feature

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-2.2
Component: pjsua-lib Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no

Description (last modified by bennylp)

This ticket fixes some bugs on the via_rewrite feature. The via_rewrite feature was introduced in pjsip version 2.0.1 by #1537.

With this ticket, the behavior regarding changing the Via sent-by is as follows:

If allow_via_rewrite is enabled, we save the Via "received" address from the response, if either of the following condition is met:

  • the Via "received" address differs from saved one (or we haven't saved any yet)
  • transport is different
  • only the port has changed, AND either the received address is public IP or allow_contact_rewrite is 2

Change History (4)

comment:1 Changed 6 years ago by bennylp

In r4545:

  • fixed bug with via_rewrite feature. The via address is not updated on second IP change

comment:2 Changed 6 years ago by bennylp

In 4546:

More re #1683:

  • also update the Via port when only the port has changed AND either the received IP is public OR allow_contact_rewrite is set to 2

comment:3 Changed 6 years ago by bennylp

In 4547:

More re #1683: added two SIPP scenarios to simulate IP/port change

comment:4 Changed 6 years ago by bennylp

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.