Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1653 closed defect (fixed)

[incompatible] pjsua_call_update() API should not release hold

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-2.2
Component: pjsua-lib Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no

Description

Bug in pjsua_call_update() API causes is to behave differently than pjsua_call_reinvite() in relation to call hold. With pjsua_call_update(), the default flags will cause call hold to be released, while with pjsua_call_reinvite() application has to explicitly specify PJSUA_CALL_UNHOLD to release hold.

This ticket changes the behavior of pjsua_call_update() to make it behave uniformly as pjsua_call_reinvite().

Unfortunately this breaks compatibility with existing application. Now if application wants to release call hold with pjsua_call_update(), it must specify PJSUA_CALL_UNHOLD in the options argument.

Change History (2)

comment:1 Changed 6 years ago by bennylp

  • Resolution set to fixed
  • Status changed from new to closed

In 4457:

Fixed #1653: [incompatible] pjsua_call_update() API should not release hold

comment:2 Changed 6 years ago by bennylp

In 4460:

More re #1653: bug in previous checkin, the local_hold flag was released regardless of the flag

Note: See TracTickets for help on using tickets.