Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1615 closed defect (fixed)

Bug in URI scheme check macro PJSIP_URI_SCHEME_IS_SIP()/SIPS/TEL

Reported by: nanang Owned by: bennylp
Priority: normal Milestone: release-2.1
Component: common Version: trunk
Keywords: Cc:
Backport to 1.x milestone: release-1.16 Backported: yes

Description

The scheme string comparison should be strict on string length, i.e: using stricmp(), instead of strnicmp(). Also need to check for their usages, known bugs:

  • pjsip-perf.c in sample app dir: need check for IS_SIPS() too
  • proxy.h in sample app dir: need check for IS_SIPS() too
  • pjsua_core.c: double IS_SIP() checks, one of them should be IS_SIPS()


Change History (4)

comment:1 Changed 7 years ago by nanang

  • Summary changed from Bug in URI scheme check macro PJSIP_URI_SCHEME_IS_* to Bug in URI scheme check macro PJSIP_URI_SCHEME_IS_SIP()/SIPS/TEL

comment:2 Changed 7 years ago by nanang

  • Resolution set to fixed
  • Status changed from new to closed

In 4370:

Close #1615: Fixed bug in URI scheme check macro PJSIP_URI_SCHEME_IS_SIP()/SIPS/TEL.

comment:3 Changed 7 years ago by riza

In 4404:

Re #1615: backported to 1.x

comment:4 Changed 7 years ago by riza

  • Backported set
Note: See TracTickets for help on using tickets.