Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#1609 closed defect (fixed)

Garbage is printed for tel: URI in the URI parameter in Authorization/Proxy-Authorization header

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-2.1
Component: pjsip Version: trunk
Keywords: Cc:
Backport to 1.x milestone: release-1.16 Backported: yes

Description (last modified by bennylp)

Garbage character will be printed if tel: URI is used in Authorization and Proxy-Authorization header. This is because the sip_auth_client.c relies on undocumented NULL termination in pjsip_uri_print(). Unfortunately the NULL termination was not added for tel: URI.

This ticket adds two fixes:

  • remove the reliance on NULL termination in sip_auth_client.c
  • add the NULL termination when printing tel: URI just in case other components use it

Thanks Bart Klin / Arkadiusz Wronski for the report.

Change History (6)

comment:1 Changed 6 years ago by bennylp

  • Resolution set to fixed
  • Status changed from new to closed

In 4320:

Fixed #1609: Garbage character may be printed after the URI parameter in Authorization/Proxy?-Authorization header

comment:2 Changed 6 years ago by bennylp

  • Description modified (diff)
  • Summary changed from Garbage character may be printed after the URI parameter in Authorization/Proxy-Authorization header to Garbage is printed for tel: URI in the URI parameter in Authorization/Proxy-Authorization header

comment:3 Changed 6 years ago by bennylp

In 4322:

Really fix #1609 after better understanding about the problem. This changeset:

  • undo r4320
  • remove the reliance on NULL termination in sip_auth_client.c
  • add the NULL termination when printing tel: URI just in case other components use it

comment:4 Changed 6 years ago by riza

  • Backported set

comment:5 Changed 6 years ago by riza

In 4399:

Re #1609: backported to 1.x

comment:6 Changed 3 years ago by nanang

In 5270:

Re #1609: Minor fix in configure scripts in ALSA detection message.

Note: See TracTickets for help on using tickets.