Opened 7 years ago

Closed 7 years ago

#1572 closed defect (fixed)

Modifying video stream in a call caused duplicate transport attributes in the SDP (thanks to Itay Bianco for the report)

Reported by: ming Owned by: bennylp
Priority: normal Milestone: release-2.1
Component: pjsua-lib Version: trunk
Keywords: Cc:
Backport to 1.x milestone: Backported: no

Description

When pjsua_vid.c's call_modify_video() is called, the current SDP will be cloned then the media transport attributes will be added to the SDP by calling pjmedia_transport_encode_sdp(). This can cause duplicate attributes if the current SDP already has media transport attributes.

To reproduce using pjsua:
Enable ICE, establish a call, modify the video stream (such as "vid call rx off 1")

Change History (1)

comment:1 Changed 7 years ago by ming

  • Resolution set to fixed
  • Status changed from new to closed

In 4236:

Fixed #1572: duplicate transport attributes when modifying video stream call
Only encode the media transport if changing the direction from NONE to !NONE.

Note: See TracTickets for help on using tickets.