Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#1242 closed enhancement (fixed)

Too many re-INVITEs sent by PJSUA-LIB, to lock codec and to conclude ICE negotiation

Reported by: bennylp Owned by: bennylp
Priority: normal Milestone: release-2.1
Component: pjsua-lib Version: trunk
Keywords: sipit28 Cc:
Backport to 1.x milestone: Backported: no

Description

If remote sends answer with multiple codecs, we will send re-INVITE to lock to one of the codec. When ICE negotiation completes, we would also need to send re-INVITE to update the default candidate (as per ICE spec).

It would be nice if these re-INVITES are combined, to reduce message round-trips, because anyway we are not able to send/receive media until ICE negotiation completes.

Based on SIPit tests, some remote may also not be able to handle re-INVITE before ICE negotiation completes.

Change History (6)

comment:1 Changed 8 years ago by bennylp

  • Milestone changed from release-1.10 to Known-Issues-and-Ideas
  • Type changed from defect to enhancement

comment:2 Changed 7 years ago by nanang

  • Backported unset
  • Milestone changed from Known-Issues-and-Ideas to release-2.0.5

comment:3 Changed 7 years ago by nanang

  • Resolution set to fixed
  • Status changed from new to closed

In 4342:

Close #1242: Single re-INVITE/UPDATE for both lock codec and ICE negotiation updates.

comment:4 Changed 7 years ago by nanang

In 4350:

Re #1242: Fixed ICE nego completion check as it always returns FALSE when peer doesn't support ICE.

comment:5 Changed 7 years ago by nanang

In 4353:

Re #1242: Fixed overridden media direction and c=0.0.0.0 line in the re-invite. For example when sending call hold and remote answers with multiple codecs, re-invite of lock codec is sent with SDP a=sendrecv line.

comment:6 Changed 7 years ago by nanang

In 4356:

Re #1242: fixed silly mistake unremoved test code.

Note: See TracTickets for help on using tickets.