Changeset 671 for pjproject/trunk/pjsip/src/pjsip/sip_dialog.c

Timestamp:

Aug 10, 2006 9:44:26 PM (18 years ago)

Author:

bennylp

Message:

Attempt to fix the race condition in dialog locking.

File:

• pjproject/trunk/pjsip/src/pjsip/sip_dialog.c (modified) (17 diffs)

pjproject/trunk/pjsip/src/pjsip/sip_dialog.c

@@ -81 +81 @@
     pj_list_init(&dlg->inv_hdr);
 
-    status = pj_mutex_create_recursive(pool, "dlg%p", &dlg->mutex);
+    status = pj_mutex_create_recursive(pool, "dlg%p", &dlg->mutex_);
     if (status != PJ_SUCCESS)
         goto on_error;
@@ -90 +90 @@
 
 on_error:
-    if (dlg->mutex)
-        pj_mutex_destroy(dlg->mutex);
+    if (dlg->mutex_)
+        pj_mutex_destroy(dlg->mutex_);
     pjsip_endpt_release_pool(endpt, pool);
     return status;
@@ -98 +98 @@
 static void destroy_dialog( pjsip_dialog *dlg )
 {
-    if (dlg->mutex)
-        pj_mutex_destroy(dlg->mutex);
+    if (dlg->mutex_) {
+        pj_mutex_destroy(dlg->mutex_);
+        dlg->mutex_ = NULL;
+    }
     pjsip_endpt_release_pool(dlg->endpt, dlg->pool);
 }
@@ -607 +609 @@
 
     /* Destroy this dialog. */
-    pj_mutex_destroy(dlg->mutex);
-    pjsip_endpt_release_pool(dlg->endpt, dlg->pool);
+    destroy_dialog(dlg);
 
     return PJ_SUCCESS;
@@ -639 +640 @@
     PJ_ASSERT_RETURN(dlg, PJ_EINVAL);
 
-    pj_mutex_lock(dlg->mutex);
+    pjsip_dlg_inc_lock(dlg);
 
     /* Clear route set. */
@@ -645 +646 @@
 
     if (!route_set) {
-        pj_mutex_unlock(dlg->mutex);
+        pjsip_dlg_dec_lock(dlg);
         return PJ_SUCCESS;
     }
@@ -659 +660 @@
     }
 
-    pj_mutex_unlock(dlg->mutex);
-
+    pjsip_dlg_dec_lock(dlg);
     return PJ_SUCCESS;
 }
@@ -673 +673 @@
     PJ_ASSERT_RETURN(dlg && mod, PJ_EINVAL);
 
-    pj_mutex_lock(dlg->mutex);
+    pjsip_dlg_inc_lock(dlg);
     ++dlg->sess_count;
-    pj_mutex_unlock(dlg->mutex);
+    pjsip_dlg_dec_lock(dlg);
 
     PJ_LOG(5,(dlg->obj_name, "Session count inc to %d by %.*s",
@@ -685 +685 @@
 /*
  * Lock dialog and increment session counter temporarily
- * to prevent it from being deleted.
+ * to prevent it from being deleted. In addition, it must lock
+ * the user agent's dialog table first, to prevent deadlock.
  */
 PJ_DEF(void) pjsip_dlg_inc_lock(pjsip_dialog *dlg)
 {
-    pj_mutex_lock(dlg->mutex);
+    pjsip_ua_lock_dlg_table();
+
+    pj_mutex_lock(dlg->mutex_);
     dlg->sess_count++;
+
+    pjsip_ua_unlock_dlg_table();
 }
 
@@ -700 +705 @@
 PJ_DEF(void) pjsip_dlg_dec_lock(pjsip_dialog *dlg)
 {
+    pjsip_ua_lock_dlg_table();
+
     pj_assert(dlg->sess_count > 0);
     --dlg->sess_count;
 
     if (dlg->sess_count==0 && dlg->tsx_count==0) {
-        pj_mutex_unlock(dlg->mutex);
-        pj_mutex_lock(dlg->mutex);
+        pj_mutex_unlock(dlg->mutex_);
+        pj_mutex_lock(dlg->mutex_);
         unregister_and_destroy_dialog(dlg);
     } else {
-        pj_mutex_unlock(dlg->mutex);
-    }
+        pj_mutex_unlock(dlg->mutex_);
+    }
+
+    pjsip_ua_unlock_dlg_table();
 }
 
@@ -725 +734 @@
               dlg->sess_count-1, (int)mod->name.slen, mod->name.ptr));
 
-    pj_mutex_lock(dlg->mutex);
+    pjsip_dlg_inc_lock(dlg);
+    --dlg->sess_count;
     pjsip_dlg_dec_lock(dlg);
 
@@ -749 +759 @@
               (int)mod->name.slen, mod->name.ptr, mod_data));
 
-    pj_mutex_lock(dlg->mutex);
+    pjsip_dlg_inc_lock(dlg);
 
     /* Usages are sorted on priority, lowest number first.
@@ -758 +768 @@
         if (dlg->usage[index] == mod) {
             pj_assert(!"This module is already registered");
-            pj_mutex_unlock(dlg->mutex);
+            pjsip_dlg_dec_lock(dlg);
             return PJSIP_ETYPEEXISTS;
         }
@@ -778 +788 @@
     ++dlg->usage_cnt;
 
-    pj_mutex_unlock(dlg->mutex);
+    pjsip_dlg_dec_lock(dlg);
 
     return PJ_SUCCESS;
@@ -897 +907 @@
 
     /* Lock dialog. */
-    pj_mutex_lock(dlg->mutex);
+    pjsip_dlg_inc_lock(dlg);
 
     /* Use outgoing CSeq and increment it by one. */
@@ -922 +932 @@
 
     /* Unlock dialog. */
-    pj_mutex_unlock(dlg->mutex);
+    pjsip_dlg_dec_lock(dlg);
 
     *p_tdata = tdata;
@@ -1114 +1124 @@
 
     /* Lock the dialog. */
-    pj_mutex_lock(dlg->mutex);
+    pjsip_dlg_inc_lock(dlg);
 
     dlg_beautify_response(dlg, st_code, tdata);
 
     /* Unlock the dialog. */
-    pj_mutex_unlock(dlg->mutex);
+    pjsip_dlg_dec_lock(dlg);
 
     /* Done. */