Changeset 657 for pjproject/trunk/pjsip/src/pjsip-ua/sip_inv.c

Timestamp:

Aug 6, 2006 11:07:25 PM (18 years ago)

Author:

bennylp

Message:

Fixed assertion error if ACK is received before INVITE transaction sends final response (malicious?). Also fixed misc warnings, and stress-tested on Quad Xeon

File:

• pjproject/trunk/pjsip/src/pjsip-ua/sip_inv.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsip-ua/sip_inv.c

@@ -257 +257 @@
     if (method->id == PJSIP_ACK_METHOD && inv) {
 
+        /* Ignore ACK if pending INVITE transaction has not finished. */
+        if (inv->invite_tsx && 
+            inv->invite_tsx->state < PJSIP_TSX_STATE_COMPLETED)
+        {
+            return PJ_TRUE;
+        }
+
         /* Terminate INVITE transaction, if it's still present. */
         if (inv->invite_tsx && 
             inv->invite_tsx->state <= PJSIP_TSX_STATE_COMPLETED)
         {
+            pj_assert(inv->invite_tsx->status_code >= 200);
             pjsip_tsx_terminate(inv->invite_tsx, 
                                 inv->invite_tsx->status_code);