Changeset 6128

Timestamp:

Jan 8, 2020 8:55:30 AM (5 years ago)

Author:

ming

Message:

Re #1778: Temporarily disable VPIO on Mac for stereo due to recording sound defects.
Steps to reproduce:

• Revert this changeset
• Use pjsua to do sound loopback (cc 0 0) with --ec-tail=0 (VPIO disabled->audio fine) and ec-tail=1 (VPIO enabled->recording sound defects)

Several observations:

• Playback is totally fine in VPIO stereo mode.
• Defect more noticable in 44.1 kHz

File:

• pjproject/trunk/pjmedia/src/pjmedia-audiodev/coreaudio_dev.m (modified) (2 diffs)

pjproject/trunk/pjmedia/src/pjmedia-audiodev/coreaudio_dev.m

@@ -1686 +1686 @@
     }
     if (param->flags & PJMEDIA_AUD_DEV_CAP_EC) {
+#if COREAUDIO_MAC
+        /* Temporarily disable VPIO on Mac for stereo due to recording sound
+         * artefacts.
+         */
+        if (param->channel_count > 1) {
+            strm->param.ec_enabled = PJ_FALSE;
+        }
+#endif
         status = ca_stream_set_cap(&strm->base,
                                    PJMEDIA_AUD_DEV_CAP_EC,
-                                   &param->ec_enabled);
+                                   &strm->param.ec_enabled);
         if (status != PJ_SUCCESS)
             strm->param.ec_enabled = PJ_FALSE;
@@ -1710 +1718 @@
     if ((param->dir == PJMEDIA_DIR_CAPTURE_PLAYBACK &&
          param->rec_id == param->play_id) ||
-        (param->flags & PJMEDIA_AUD_DEV_CAP_EC && param->ec_enabled))
+        (param->flags & PJMEDIA_AUD_DEV_CAP_EC && strm->param.ec_enabled))
     {
         /* If both input and output are on the same device or if EC is enabled,