Changeset 6128


Ignore:
Timestamp:
Jan 8, 2020 8:55:30 AM (11 months ago)
Author:
ming
Message:

Re #1778: Temporarily disable VPIO on Mac for stereo due to recording sound defects.
Steps to reproduce:

  • Revert this changeset
  • Use pjsua to do sound loopback (cc 0 0) with --ec-tail=0 (VPIO disabled->audio fine) and ec-tail=1 (VPIO enabled->recording sound defects)

Several observations:

  • Playback is totally fine in VPIO stereo mode.
  • Defect more noticable in 44.1 kHz
File:
1 edited

Legend:

Unmodified
Added
Removed
  • pjproject/trunk/pjmedia/src/pjmedia-audiodev/coreaudio_dev.m

    r6127 r6128  
    16861686    } 
    16871687    if (param->flags & PJMEDIA_AUD_DEV_CAP_EC) { 
     1688#if COREAUDIO_MAC 
     1689        /* Temporarily disable VPIO on Mac for stereo due to recording sound 
     1690         * artefacts. 
     1691         */ 
     1692        if (param->channel_count > 1) { 
     1693            strm->param.ec_enabled = PJ_FALSE; 
     1694        } 
     1695#endif 
    16881696        status = ca_stream_set_cap(&strm->base, 
    16891697                                   PJMEDIA_AUD_DEV_CAP_EC, 
    1690                                    &param->ec_enabled); 
     1698                                   &strm->param.ec_enabled); 
    16911699        if (status != PJ_SUCCESS) 
    16921700            strm->param.ec_enabled = PJ_FALSE; 
     
    17101718    if ((param->dir == PJMEDIA_DIR_CAPTURE_PLAYBACK && 
    17111719         param->rec_id == param->play_id) || 
    1712         (param->flags & PJMEDIA_AUD_DEV_CAP_EC && param->ec_enabled)) 
     1720        (param->flags & PJMEDIA_AUD_DEV_CAP_EC && strm->param.ec_enabled)) 
    17131721    { 
    17141722        /* If both input and output are on the same device or if EC is enabled, 
Note: See TracChangeset for help on using the changeset viewer.