Changeset 6105 for pjproject/trunk/pjmedia/include/pjmedia-codec/types.h

Timestamp:

Nov 13, 2019 8:09:34 AM (4 years ago)

Author:

nanang

Message:

Close #1297:

• Updated PJMEDIA endpoint to rearrange dynamic payload type allocation in generating SDP for audio, the allocation arranged in pjmedia_audio_pt enumeation is no longer used.
• Updated PJMEDIA_RTP_PT_TELEPHONE_EVENTS default value to 120, so lower PT values will be used by audio codecs.

File:

• pjproject/trunk/pjmedia/include/pjmedia-codec/types.h (modified) (2 diffs)

pjproject/trunk/pjmedia/include/pjmedia-codec/types.h

@@ -42 +42 @@
  * this library. Also see the header file <pjmedia/codec.h> for list
  * of static payload types.
+ *
+ * These enumeration is for older audio codecs only, newer audio codec using
+ * dynamic payload type can simply assign PJMEDIA_RTP_PT_DYNAMIC in its
+ * payload type (i.e: pjmedia_codec_info.pt). Endpoint will automatically
+ * rearrange dynamic payload types in SDP generation.
  */
 enum pjmedia_audio_pt
 {
     /* According to IANA specifications, dynamic payload types are to be in
-     * the range 96-127 (inclusive). This enum is structured to place the
-     * values of the payload types specified below into that range.
+     * the range 96-127 (inclusive), but this enum allows the value to be
+     * outside that range, later endpoint will rearrange dynamic payload types
+     * in SDP generation to be inside the 96-127 range and not equal to
+     * PJMEDIA_RTP_PT_TELEPHONE_EVENTS.
      *
      * PJMEDIA_RTP_PT_DYNAMIC is defined in <pjmedia/codec.h>. It is defined
      * to be 96.
-     *
-     * PJMEDIA_RTP_PT_TELEPHONE_EVENTS is defined in <pjmedia/config.h>.
-     * The default value is 96.
      */
-#if PJMEDIA_RTP_PT_TELEPHONE_EVENTS
-    PJMEDIA_RTP_PT_START = PJMEDIA_RTP_PT_TELEPHONE_EVENTS,
-#else
     PJMEDIA_RTP_PT_START = (PJMEDIA_RTP_PT_DYNAMIC-1),
-#endif
 
     PJMEDIA_RTP_PT_SPEEX_NB,                    /**< Speex narrowband/8KHz  */
@@ -109 +109 @@
     PJMEDIA_RTP_PT_L16_48KHZ_STEREO,            /**< L16 @ 48KHz, stereo    */
 #endif
-
-    /* Caution!
-     * Ensure the value of the last pt above is <= 127.
-     */
 };