Changeset 5970

Timestamp:

Apr 16, 2019 4:08:04 AM (5 years ago)

Author:

ming

Message:

Fixed #2190: Crash in ioqueue post completion if callback is not set

File:

• pjproject/trunk/pjlib/src/pj/ioqueue_common_abs.c (modified) (3 diffs)

pjproject/trunk/pjlib/src/pj/ioqueue_common_abs.c

@@ -1281 +1281 @@
             pj_ioqueue_unlock_key(key);
 
-            (*key->cb.on_read_complete)(key, op_key, bytes_status);
+            if (key->cb.on_read_complete)
+                (*key->cb.on_read_complete)(key, op_key, bytes_status);
             return PJ_SUCCESS;
         }
@@ -1295 +1296 @@
             pj_ioqueue_unlock_key(key);
 
-            (*key->cb.on_write_complete)(key, op_key, bytes_status);
+            if (key->cb.on_write_complete)
+                (*key->cb.on_write_complete)(key, op_key, bytes_status);
             return PJ_SUCCESS;
         }
@@ -1309 +1311 @@
             pj_ioqueue_unlock_key(key);
 
-            (*key->cb.on_accept_complete)(key, op_key, 
-                                          PJ_INVALID_SOCKET,
-                                          (pj_status_t)bytes_status);
+            if (key->cb.on_accept_complete) {
+                (*key->cb.on_accept_complete)(key, op_key, 
+                                              PJ_INVALID_SOCKET,
+                                              (pj_status_t)bytes_status);
+            }
             return PJ_SUCCESS;
         }