Changeset 5969

Timestamp:

Apr 15, 2019 10:52:16 AM (6 years ago)

Author:

nanang

Message:

Close #2189: fixed PJSUA2 thread safety issue in list of objects manipulation.

Location:

pjproject/trunk

Files:

• pjsip-apps/src/swig/java/android/app/src/main/java/org/pjsip/pjsua2/app/MyApp.java (modified) (2 diffs)
• pjsip-apps/src/swig/pjsua2.i (modified) (2 diffs)
• pjsip/include/pjsua2/account.hpp (modified) (4 diffs)
• pjsip/include/pjsua2/call.hpp (modified) (4 diffs)
• pjsip/include/pjsua2/endpoint.hpp (modified) (8 diffs)
• pjsip/include/pjsua2/media.hpp (modified) (19 diffs)
• pjsip/include/pjsua2/presence.hpp (modified) (5 diffs)
• pjsip/src/pjsua2/account.cpp (modified) (2 diffs)
• pjsip/src/pjsua2/call.cpp (modified) (2 diffs)
• pjsip/src/pjsua2/endpoint.cpp (modified) (8 diffs)
• pjsip/src/pjsua2/media.cpp (modified) (6 diffs)
• pjsip/src/pjsua2/presence.cpp (modified) (6 diffs)

pjproject/trunk/pjsip-apps/src/swig/java/android/app/src/main/java/org/pjsip/pjsua2/app/MyApp.java

@@ -98 +98 @@
                         pjsua_call_media_status.PJSUA_CALL_MEDIA_REMOTE_HOLD))
             {
-                // unfortunately, on Java too, the returned Media cannot be
-                // downcasted to AudioMedia 
-                Media m = getMedia(i);
-                AudioMedia am = AudioMedia.typecastFromMedia(m);
-
                 // connect ports
                 try {
+                    AudioMedia am = getAudioMedia(i);
                     MyApp.ep.audDevManager().getCaptureDevMedia().
                                                             startTransmit(am);
@@ -110 +106 @@
                                      getPlaybackDevMedia());
                 } catch (Exception e) {
+                    System.out.println("Failed connecting media ports" +
+                                       e.getMessage());
                     continue;
                 }

pjproject/trunk/pjsip-apps/src/swig/pjsua2.i

@@ -106 +106 @@
 %template(SipMultipartPartVector)       std::vector<pj::SipMultipartPart>;
 %template(BuddyVector)                  std::vector<pj::Buddy*>;
+%template(BuddyVector2)                 std::vector<pj::Buddy>;
 %template(AudioMediaVector)             std::vector<pj::AudioMedia*>;
+%template(AudioMediaVector2)            std::vector<pj::AudioMedia>;
 %template(ToneDescVector)               std::vector<pj::ToneDesc>;
 %template(ToneDigitVector)              std::vector<pj::ToneDigit>;
 %template(ToneDigitMapVector)           std::vector<pj::ToneDigitMapDigit>;
-%template(MediaFormatVector)            std::vector<pj::MediaFormat*>;
 %template(AudioDevInfoVector)           std::vector<pj::AudioDevInfo*>;
+%template(AudioDevInfoVector2)          std::vector<pj::AudioDevInfo>;
 %template(CodecInfoVector)              std::vector<pj::CodecInfo*>;
+%template(CodecInfoVector2)             std::vector<pj::CodecInfo>;
 %template(VideoDevInfoVector)           std::vector<pj::VideoDevInfo*>;
+%template(VideoDevInfoVector2)          std::vector<pj::VideoDevInfo>;
 %template(CodecFmtpVector)              std::vector<pj::CodecFmtp>;     
+%template(MediaFormatAudioVector)       std::vector<pj::MediaFormatAudio>;
+%template(MediaFormatVideoVector)       std::vector<pj::MediaFormatVideo>;
+%template(CallMediaInfoVector)          std::vector<pj::CallMediaInfo>;
+%template(RtcpFbCapVector)              std::vector<pj::RtcpFbCap>;
+%template(SslCertNameVector)            std::vector<pj::SslCertName>;
 
 %ignore pj::WindowHandle::display;
@@ -145 +154 @@
 %include "pjsua2/call.hpp"
 
-%template(CallMediaInfoVector)          std::vector<pj::CallMediaInfo>;
-
 %ignore pj::JsonDocument::allocElement;
 %ignore pj::JsonDocument::getPool;

pjproject/trunk/pjsip/include/pjsua2/account.hpp

@@ -1649 +1649 @@
      * and delete the corresponding account in the PJSUA-LIB.
      *
+     * Note that application must delete all Buddy instances belong to this
+     * account before shutting down the account.
+     *
      * If application implements a derived class, the derived class should
      * call this method in the beginning stage in its destructor, or
@@ -1760 +1763 @@
     
     /**
+     * Warning: deprecated, use enumBuddies2() instead. This function is not
+     * safe in multithreaded environment.
+     *
      * Enumerate all buddies of the account.
      *
@@ -1767 +1773 @@
 
     /**
+     * Enumerate all buddies of the account.
+     *
+     * @return                  The buddy list.
+     */
+    BuddyVector2 enumBuddies2() const throw(Error);
+
+    /**
+     * Warning: deprecated, use findBuddy2 instead. This function is not
+     * safe in multithreaded environment.
+     *
      * Find a buddy in the buddy list with the specified URI. 
      *
@@ -1778 +1794 @@
     Buddy* findBuddy(string uri, FindBuddyMatch *buddy_match = NULL) const
                     throw(Error);
+
+    /**
+     * Find a buddy in the buddy list with the specified URI. 
+     *
+     * Exception: if buddy is not found, PJ_ENOTFOUND will be thrown.
+     *
+     * @param uri               The buddy URI.
+     *
+     * @return                  The pointer to buddy.
+     */
+    Buddy findBuddy2(string uri) const throw(Error);
 
 public:

pjproject/trunk/pjsip/include/pjsua2/call.hpp

@@ -312 +312 @@
      * Default constructor initializes with empty or default values.
      */
-    CallSetting(pj_bool_t useDefaultValues = false);
+    CallSetting(bool useDefaultValues = false);
 
     /**
@@ -1010 +1010 @@
      * which are going to be used.
      */
-    vector<SrtpCrypto>          cryptos;
+    SrtpCryptoVector            cryptos;
 };
 
@@ -1236 +1236 @@
     
     /**
+     * Warning: deprecated, use getAudioMedia() instead. This function is not
+     * safe in multithreaded environment.
+     *
      * Get media for the specified media index.
      *
@@ -1243 +1246 @@
      */
     Media *getMedia(unsigned med_idx) const;
+
+    /**
+     * Get audio media for the specified media index. If the specified media
+     * index is not audio or invalid or inactive, exception will be thrown.
+     *
+     * @param med_idx       Media index.
+     *
+     * @return              The audio media.
+     */
+    AudioMedia getAudioMedia(unsigned med_idx) const throw(Error);
 
     /**

pjproject/trunk/pjsip/include/pjsua2/endpoint.hpp

@@ -133 +133 @@
 };
 
+/** Array of SSL certificate type and name. */
+typedef std::vector<SslCertName> SslCertNameVector;
+
 /**
  * SSL certificate information.
@@ -156 +159 @@
                                                  date/time use GMT      */
 
-    vector<SslCertName> subjectAltName;     /**< Subject alternative
+    SslCertNameVector   subjectAltName;     /**< Subject alternative
                                                  name extension         */
 
@@ -1379 +1382 @@
 
     /**
+     * Warning: deprecated, use mediaEnumPorts2() instead. This function is
+     * not safe in multithreaded environment.
+     *
      * Enumerate all media port.
      *
@@ -1384 +1390 @@
      */
     const AudioMediaVector &mediaEnumPorts() const throw(Error);
+
+    /**
+     * Enumerate all audio media port.
+     *
+     * @return          The list of audio media port.
+     */
+    AudioMediaVector2 mediaEnumPorts2() const throw(Error);
 
     /**
@@ -1404 +1417 @@
 
     /**
+     * Warning: deprecated, use codecEnum2() instead. This function is not
+     * safe in multithreaded environment.
+     *
      * Enum all supported codecs in the system.
      *
@@ -1409 +1425 @@
      */
     const CodecInfoVector &codecEnum() throw(Error);
+
+    /**
+     * Enum all supported codecs in the system.
+     *
+     * @return          Array of codec info.
+     */
+    CodecInfoVector2 codecEnum2() const throw(Error);
 
     /**
@@ -1445 +1468 @@
 
     /**
+     * Warning: deprecated, use videoCodecEnum2() instead. This function is
+     * not safe in multithreaded environment.
+     *
      * Enum all supported video codecs in the system.
      *  
@@ -1450 +1476 @@
      */
     const CodecInfoVector &videoCodecEnum() throw(Error);
+
+    /**
+     * Enum all supported video codecs in the system.
+     *  
+     * @return          Array of video codec info.
+     */
+    CodecInfoVector2 videoCodecEnum2() const throw(Error);
 
     /**

pjproject/trunk/pjsip/include/pjsua2/media.hpp

@@ -214 +214 @@
 
 /**
- * Audio Media.
+ * Audio Media. This is a lite wrapper class for audio conference bridge port,
+ * i.e: this class only maintains one data member, conference slot ID, and 
+ * the methods are simply proxies for conference bridge operations.
+ *
+ * Application can create a derived class and use registerMediaPort2()/
+ * unregisterMediaPort() to register/unregister a media port to/from the
+ * conference bridge.
+ *
+ * The library will not keep a list of AudioMedia instances, so any
+ * AudioMedia (descendant) instances instantiated by application must be
+ * maintained and destroyed by the application itself.
+ *
+ * Note that any PJSUA2 APIs that return AudioMedia instance(s) such as
+ * Endpoint::mediaEnumPorts2() or Call::getAudioMedia() will just return
+ * generated copy. All AudioMedia methods should work normally on this
+ * generated copy instance.
  */
 class AudioMedia : public Media
@@ -321 +336 @@
 
     /**
+     * Warning: deprecated and will be removed in future release.
+     *
      * Typecast from base class Media. This is useful for application written
      * in language that does not support downcasting such as Python.
@@ -331 +348 @@
 
     /**
-     * Virtual Destructor
+     * Default Constructor. Normally application will not create AudioMedia
+     * object directly, but it may instantiate an AudioMedia derived class.
+     */
+    AudioMedia();
+
+    /**
+     * Virtual Destructor.
      */
     virtual ~AudioMedia();
@@ -343 +366 @@
 protected:
     /**
-     * Default Constructor.
-     */
-    AudioMedia();
-
-    /**
+     * Warning: deprecated and will be removed in future release, use
+     * registerMediaPort2() instead.
+     *
      * This method needs to be called by descendants of this class to register
      * the media port created to the conference bridge and Endpoint's
      * media list.
      *
-     * param port  the media port to be registered to the conference bridge.
+     * param port  The media port to be registered to the conference bridge.
      *
      */
     void registerMediaPort(MediaPort port) throw(Error);
+
+    /**
+     * This method needs to be called by descendants of this class to register
+     * the media port created to the conference bridge and Endpoint's
+     * media list.
+     *
+     * param port  The media port to be registered to the conference bridge.
+     * param pool  The memory pool.
+     *
+     */
+    void registerMediaPort2(MediaPort port, pj_pool_t *pool) throw(Error);
 
     /**
@@ -366 +398 @@
 
 private:
+    /* Memory pool for deprecated registerMediaPort() */
     pj_caching_pool      mediaCachingPool;
     pj_pool_t           *mediaPool;
-};
+
+    friend class Endpoint;
+};
+
+/** 
+ * Warning: deprecated, use AudioMediaVector2 instead.
+ *
+ * Array of Audio Media.
+ */
+typedef std::vector<AudioMedia*> AudioMediaVector;
+
 
 /** Array of Audio Media */
-typedef std::vector<AudioMedia*> AudioMediaVector;
+typedef std::vector<AudioMedia> AudioMediaVector2;
 
 /**
@@ -465 +508 @@
 
     /**
+     * Warning: deprecated and will be removed in future release.
+     *
      * Typecast from base class AudioMedia. This is useful for application
      * written in language that does not support downcasting such as Python.
@@ -475 +520 @@
 
     /**
-     * Destructor.
+     * Destructor. This will unregister the player port from the conference
+     * bridge.
      */
     virtual ~AudioMediaPlayer();
@@ -546 +592 @@
     void createRecorder(const string &file_name,
                         unsigned enc_type=0,
-                        pj_ssize_t max_size=0,
+                        long max_size=0,
                         unsigned options=0) throw(Error);
 
     /**
+     * Warning: deprecated and will be removed in future release.
+     *
      * Typecast from base class AudioMedia. This is useful for application
      * written in language that does not support downcasting such as Python.
@@ -560 +608 @@
 
     /**
-     * Destructor.
+     * Destructor. This will unregister the recorder port from the conference
+     * bridge.
      */
     virtual ~AudioMediaRecorder();
@@ -635 +684 @@
 
     /**
-     * Destructor.
+     * Destructor. This will unregister the tone generator port from the
+     * conference bridge.
      */
     ~ToneGenerator();
 
     /**
-     * Create tone generator.
+     * Create tone generator and register the port to the conference bridge.
      */
     void createToneGenerator(unsigned clock_rate = 16000,
@@ -776 +826 @@
 };
 
+/** 
+ * Warning: deprecated, use AudioDevInfoVector2 instead.
+ *
+ * Array of audio device info.
+ */
+typedef std::vector<AudioDevInfo*> AudioDevInfoVector;
+
 /** Array of audio device info */
-typedef std::vector<AudioDevInfo*> AudioDevInfoVector;
+typedef std::vector<AudioDevInfo> AudioDevInfoVector2;
 
 /**
@@ -836 +893 @@
 
     /**
+     * Warning: deprecated, use enumDev2 instead. This function is not
+     * safe in multithreaded environment.
+     *
+     * Enum all audio devices installed in the system. This function is not
+     * safe in multithreaded environment.
+     *
+     * @return                  The list of audio device info.
+     */
+    const AudioDevInfoVector &enumDev() throw(Error);
+
+    /**
      * Enum all audio devices installed in the system.
      *
      * @return                  The list of audio device info.
      */
-    const AudioDevInfoVector &enumDev() throw(Error);
+    AudioDevInfoVector2 enumDev2() const throw(Error);
 
     /**
@@ -1417 +1485 @@
 public:
     /**
-     * Constructor
+     * Constructor.
      *
      * @param playdev           Playback device ID.
@@ -1425 +1493 @@
 
     /**
-     * Destructor
+     * Destructor.
      */
     virtual ~ExtraAudioDevice();
@@ -1432 +1500 @@
      * Open the audio device using format (e.g.: clock rate, bit per sample,
      * samples per frame) matched to the conference bridge's format, except
-     * the channel count, which will be set to one (mono channel).
+     * the channel count, which will be set to one (mono channel). This will
+     * also register the audio device port to conference bridge.
      */
     void open();
 
     /**
-     * Close the audio device.
+     * Close the audio device and unregister the audio device port from the
+     * conference bridge.
      */
     void close();
@@ -1766 +1836 @@
 };
 
+/** 
+ * Warning: deprecated, use VideoDevInfoVector2 instead.
+ *
+ * Array of video device info.
+ */
+typedef std::vector<VideoDevInfo*> VideoDevInfoVector;
+
 /** Array of video device info */
-typedef std::vector<VideoDevInfo*> VideoDevInfoVector;
+typedef std::vector<VideoDevInfo> VideoDevInfoVector2;
 
 /**
@@ -1813 +1890 @@
 
     /**
+     * Warning: deprecated, use enumDev2() instead. This function is not
+     * safe in multithreaded environment.
+     *
      * Enum all video devices installed in the system.
      *
@@ -1818 +1898 @@
      */
     const VideoDevInfoVector &enumDev() throw(Error);
+
+    /**
+     * Enum all video devices installed in the system.
+     *
+     * @return          The list of video device info
+     */
+    VideoDevInfoVector2 enumDev2() const throw(Error);
 
     /**
@@ -2056 +2143 @@
 };
 
+/** 
+ * Warning: deprecated, use CodecInfoVector2 instead.
+ *
+ * Array of codec info.
+ */
+typedef std::vector<CodecInfo*> CodecInfoVector;
+
 /** Array of codec info */
-typedef std::vector<CodecInfo*> CodecInfoVector;
+typedef std::vector<CodecInfo> CodecInfoVector2;
 
 /**

pjproject/trunk/pjsip/include/pjsua2/presence.hpp

@@ -169 +169 @@
      */
     PresenceStatus       presStatus;
-    
+
 public:
     /** Import from pjsip structure */
@@ -189 +189 @@
 
 /**
- * Buddy.
+ * Buddy. This is a lite wrapper class for PJSUA-LIB buddy, i.e: this class
+ * only maintains one data member, PJSUA-LIB buddy ID, and the methods are
+ * simply proxies for PJSUA-LIB buddy operations.
+ *
+ * Application can use create() to register a buddy to PJSUA-LIB, and
+ * the destructor of the original instance (i.e: the instance that calls
+ * create()) will unregister and delete the buddy from PJSUA-LIB. Application
+ * must delete all Buddy instances belong to an account before shutting down
+ * the account (via Account::shutdown()).
+ *
+ * The library will not keep a list of Buddy instances, so any Buddy (or
+ * descendant) instances instantiated by application must be maintained
+ * and destroyed by the application itself. Any PJSUA2 APIs that return Buddy
+ * instance(s) such as Account::enumBuddies2() or Account::findBuddy2() will
+ * just return generated copy. All Buddy methods should work normally on this
+ * generated copy instance.
  */
 class Buddy
@@ -200 +215 @@
     
     /**
-     * Destructor. Note that if the Buddy instance is deleted, it will also
-     * delete the corresponding buddy in the PJSUA-LIB.
+     * Destructor. Note that if the Buddy original instance (i.e: the instance
+     * that calls Buddy::create()) is destroyed, it will also delete the
+     * corresponding buddy in the PJSUA-LIB. While the destructor of
+     * a generated copy (i.e: Buddy instance returned by PJSUA2 APIs such as
+     * Account::enumBuddies2() or Account::findBuddy2()) will do nothing.
      */
     virtual ~Buddy();
@@ -207 +225 @@
     /**
      * Create buddy and register the buddy to PJSUA-LIB.
+     *
+     * Note that application should maintain the Buddy original instance, i.e:
+     * the instance that calls this create() method as it is only the original
+     * instance destructor that will delete the underlying Buddy in PJSUA-LIB.
      *
      * @param acc               The account for this buddy.
@@ -298 +320 @@
       * Buddy ID.
       */
-     pjsua_buddy_id      id;
-     
-     /**
-      * Account.
-      */
-     Account            *acc;
-};
-
+    pjsua_buddy_id       id;
+
+private:
+    friend class Endpoint;
+    friend class Account;
+
+    /* Internal constructor/methods used by Endpoint and Account */
+    Buddy(pjsua_buddy_id buddy_id);
+    Buddy *getOriginalInstance();
+};
+
+
+/**
+ * Warning: deprecated, use BuddyVector2 instead.
+ *
+ * Array of buddies.
+ */
+typedef std::vector<Buddy*> BuddyVector;
 
 /** Array of buddies */
-typedef std::vector<Buddy*> BuddyVector;
+typedef std::vector<Buddy> BuddyVector2;
 
 

pjproject/trunk/pjsip/src/pjsua2/account.cpp

@@ -1029 +1029 @@
 }
 
+BuddyVector2 Account::enumBuddies2() const throw(Error)
+{
+    BuddyVector2 bv2;
+    pjsua_buddy_id ids[PJSUA_MAX_BUDDIES];
+    unsigned i, count = PJSUA_MAX_BUDDIES;
+
+    PJSUA2_CHECK_EXPR( pjsua_enum_buddies(ids, &count) );
+    for (i = 0; i < count; ++i) {
+        bv2.push_back(Buddy(ids[i]));
+    }
+
+    return bv2;
+}
+
 Buddy* Account::findBuddy(string uri, FindBuddyMatch *buddy_match) const
                 throw(Error)
@@ -1042 +1056 @@
     }
     PJSUA2_RAISE_ERROR(PJ_ENOTFOUND);
+}
+
+Buddy Account::findBuddy2(string uri) const throw(Error)
+{
+    pj_str_t pj_uri;
+    pjsua_buddy_id id;
+
+    pj_strset2(&pj_uri, (char*)uri.c_str());
+
+    id = pjsua_buddy_find(&pj_uri);
+    if (id == PJSUA_INVALID_ID) {
+        PJSUA2_RAISE_ERROR(PJ_ENOTFOUND);
+    }
+
+    Buddy buddy(id);
+    return buddy;
 }
 

pjproject/trunk/pjsip/src/pjsua2/call.cpp

@@ -228 +228 @@
 }
 
-CallSetting::CallSetting(pj_bool_t useDefaultValues)
+CallSetting::CallSetting(bool useDefaultValues)
 {
     if (useDefaultValues) {
@@ -522 +522 @@
 }
 
+AudioMedia Call::getAudioMedia(unsigned med_idx) const throw(Error)
+{
+    CallAudioMedia cam;
+    CallInfo ci = getInfo();
+
+    if (med_idx < ci.media.size() &&
+        ci.media[med_idx].type == PJMEDIA_TYPE_AUDIO)
+    {
+        cam.setPortId(ci.media[med_idx].audioConfSlot);
+    }
+    return cam;
+}
+
 pjsip_dialog_cap_status Call::remoteHasCap(int htype,
                                            const string &hname,

pjproject/trunk/pjsip/src/pjsua2/endpoint.cpp

@@ -978 +978 @@
 void Endpoint::on_buddy_state(pjsua_buddy_id buddy_id)
 {
-    Buddy *buddy = (Buddy*)pjsua_buddy_get_user_data(buddy_id);
+    Buddy b(buddy_id);
+    Buddy *buddy = b.getOriginalInstance();
     if (!buddy || !buddy->isValid()) {
         /* Ignored */
@@ -993 +994 @@
     PJ_UNUSED_ARG(sub);
 
-    Buddy *buddy = (Buddy*)pjsua_buddy_get_user_data(buddy_id);
+    Buddy b(buddy_id);
+    Buddy *buddy = b.getOriginalInstance();
     if (!buddy || !buddy->isValid()) {
         /* Ignored */
@@ -2045 +2047 @@
 }
 
+AudioMediaVector2 Endpoint::mediaEnumPorts2() const throw(Error)
+{
+    AudioMediaVector2 amv2;
+    pjsua_conf_port_id ids[PJSUA_MAX_CONF_PORTS];
+    unsigned i, count = PJSUA_MAX_CONF_PORTS;
+
+    PJSUA2_CHECK_EXPR( pjsua_enum_conf_ports(ids, &count) );
+    for (i = 0; i < count; ++i) {
+        AudioMedia am;
+        am.id = ids[i];
+        amv2.push_back(am);
+    }
+
+    return amv2;
+}
+
 void Endpoint::mediaAdd(AudioMedia &media)
 {
+    /* mediaList serves mediaEnumPorts() only, once mediaEnumPorts()
+     * is removed, this function implementation should be no-op.
+     */
     pj_mutex_lock(mediaListMutex);
 
@@ -2060 +2081 @@
 void Endpoint::mediaRemove(AudioMedia &media)
 {
+    /* mediaList serves mediaEnumPorts() only, once mediaEnumPorts()
+     * is removed, this function implementation should be no-op.
+     */
     pj_mutex_lock(mediaListMutex);
     AudioMediaVector::iterator it = std::find(mediaList.begin(),
@@ -2067 +2091 @@
     if (it != mediaList.end())
         mediaList.erase(it);
-
     pj_mutex_unlock(mediaListMutex);
 }
@@ -2073 +2096 @@
 bool Endpoint::mediaExists(const AudioMedia &media) const
 {
-    bool exists;
-
-    pj_mutex_lock(mediaListMutex);
-    AudioMediaVector::const_iterator it = std::find(mediaList.begin(),
-                                                    mediaList.end(),
-                                                    &media);
-    exists = (it != mediaList.end());
-    pj_mutex_unlock(mediaListMutex);
-    return exists;
+    pjsua_conf_port_id id = media.getPortId();
+    if (id == PJSUA_INVALID_ID || id >= (int)mediaMaxPorts())
+        return false;
+
+    pjsua_conf_port_info pi;
+    return (pjsua_conf_get_port_info(id, &pi) == PJ_SUCCESS);
 }
 
@@ -2108 +2128 @@
 }
 
+CodecInfoVector2 Endpoint::codecEnum2() const throw(Error)
+{
+    CodecInfoVector2 civ2;
+    pjsua_codec_info pj_codec[MAX_CODEC_NUM];
+    unsigned count = MAX_CODEC_NUM;
+
+    PJSUA2_CHECK_EXPR( pjsua_enum_codecs(pj_codec, &count) );
+    for (unsigned i = 0; i<count; ++i) {
+        CodecInfo codec_info;
+        codec_info.fromPj(pj_codec[i]);
+        civ2.push_back(codec_info);
+    }
+    return civ2;
+}
+
 void Endpoint::codecSetPriority(const string &codec_id,
                                 pj_uint8_t priority) throw(Error)
@@ -2169 +2204 @@
 #endif
     return videoCodecInfoList;
+}
+
+CodecInfoVector2 Endpoint::videoCodecEnum2() const throw(Error)
+{
+    CodecInfoVector2 civ2;
+#if PJSUA_HAS_VIDEO
+    pjsua_codec_info pj_codec[MAX_CODEC_NUM];
+    unsigned count = MAX_CODEC_NUM;
+
+    PJSUA2_CHECK_EXPR(pjsua_vid_enum_codecs(pj_codec, &count));
+    for (unsigned i = 0; i<count; ++i) {
+        CodecInfo codec_info;
+        codec_info.fromPj(pj_codec[i]);
+        civ2.push_back(codec_info);
+    }
+#endif
+    return civ2;
 }
 

pjproject/trunk/pjsip/src/pjsua2/media.cpp

@@ -158 +158 @@
 }
 
+void AudioMedia::registerMediaPort2(MediaPort port, pj_pool_t *pool)
+     throw(Error)
+{
+    /* Check if media already added to Conf bridge. */
+    pj_assert(!Endpoint::instance().mediaExists(*this));
+
+    if (port != NULL) {
+        pj_assert(id == PJSUA_INVALID_ID);
+        pj_assert(pool);
+
+        PJSUA2_CHECK_EXPR( pjsua_conf_add_port(pool,
+                                               (pjmedia_port *)port,
+                                               &id) );
+    }
+
+    Endpoint::instance().mediaAdd(*this);
+}
+
 void AudioMedia::unregisterMediaPort()
 {
@@ -176 +194 @@
 AudioMedia::~AudioMedia() 
 {
-    unregisterMediaPort();
 }
 
@@ -409 +426 @@
 void AudioMediaRecorder::createRecorder(const string &file_name,
                                         unsigned enc_type,
-                                        pj_ssize_t max_size,
+                                        long max_size,
                                         unsigned options)
                                         throw(Error)
@@ -481 +498 @@
     }
 
-    registerMediaPort(tonegen);
+    registerMediaPort2(tonegen, pool);
 }
 
@@ -746 +763 @@
     pj_leave_critical_section();
     return audioDevList;
+}
+
+AudioDevInfoVector2 AudDevManager::enumDev2() const throw(Error)
+{
+    pjmedia_aud_dev_info pj_info[MAX_DEV_COUNT];
+    unsigned count = MAX_DEV_COUNT;
+    AudioDevInfoVector2 adiv2;
+
+    PJSUA2_CHECK_EXPR( pjsua_enum_aud_devs(pj_info, &count) );
+
+    for (unsigned i = 0; i<count ;++i) {
+        AudioDevInfo di;
+        di.fromPj(pj_info[i]);
+        adiv2.push_back(di);
+    }
+
+    return adiv2;
 }
 
@@ -1427 +1461 @@
 }
 
+VideoDevInfoVector2 VidDevManager::enumDev2() const throw(Error)
+{
+    VideoDevInfoVector2 vdiv2;
+#if PJSUA_HAS_VIDEO
+    pjmedia_vid_dev_info pj_info[MAX_DEV_COUNT];
+    unsigned count = MAX_DEV_COUNT;
+
+    PJSUA2_CHECK_EXPR(pjsua_vid_enum_devs(pj_info, &count));
+
+    for (unsigned i = 0; i<count;++i) {
+        VideoDevInfo vdi;
+        vdi.fromPj(pj_info[i]);
+        vdiv2.push_back(vdi);
+    }
+#endif
+    return vdiv2;
+}
+
 int VidDevManager::lookupDev(const string &drv_name,
                              const string &dev_name) const throw(Error)

pjproject/trunk/pjsip/src/pjsua2/presence.cpp

@@ -74 +74 @@
 
 //////////////////////////////////////////////////////////////////////////////
+typedef struct BuddyUserData
+{
+    Buddy       *self;
+    Account     *acc;
+} BuddyUserData;
 
 /*
@@ -83 +88 @@
 }
  
+Buddy::Buddy(pjsua_buddy_id buddy_id)
+: id(buddy_id)
+{
+}
+
+Buddy *Buddy::getOriginalInstance()
+{
+    BuddyUserData *bud = (BuddyUserData*)pjsua_buddy_get_user_data(id);
+    return (bud? bud->self : NULL);
+}
+
 /*
  * Destructor.
@@ -88 +104 @@
 Buddy::~Buddy()
 {
-    if (isValid()) {
+    if (isValid() && getOriginalInstance()==this) {
+        Account *acc = NULL;
+        BuddyUserData *bud = (BuddyUserData*)pjsua_buddy_get_user_data(id);
+        if (bud) {
+            acc = bud->acc;
+            delete bud;
+        }
+
         pjsua_buddy_set_user_data(id, NULL);
         pjsua_buddy_del(id);
 
         /* Remove from account buddy list */
-        acc->removeBuddy(this);
+        if (acc)
+            acc->removeBuddy(this);
     }
 }
@@ -108 +132 @@
         PJSUA2_RAISE_ERROR3(PJ_EINVAL, "Buddy::create()", "Invalid account");
     
+    BuddyUserData *bud = new BuddyUserData();
+    bud->self = this;
+    bud->acc  = &account;
+
     pj_cfg.uri = str2Pj(cfg.uri);
     pj_cfg.subscribe = cfg.subscribe;
-    pj_cfg.user_data = (void*)this;
+    pj_cfg.user_data = (void*)bud;
     PJSUA2_CHECK_EXPR( pjsua_buddy_add(&pj_cfg, &id) );
     
-    acc = &account;
-    acc->addBuddy(this);
+    account.addBuddy(this);
 }
     
@@ -161 +188 @@
 {
     BuddyInfo bi = getInfo();
+    BuddyUserData *bud = (BuddyUserData*)pjsua_buddy_get_user_data(id);
+    Account *acc = bud? bud->acc : NULL;
+
+    if (!bud || !acc || !acc->isValid()) {
+        PJSUA2_RAISE_ERROR3(PJ_EINVAL, "sendInstantMessage()",
+                            "Invalid Buddy");
+    }
 
     pj_str_t to = str2Pj(bi.contact.empty()? bi.uri : bi.contact);
@@ -180 +214 @@
 {
     BuddyInfo bi = getInfo();
+    BuddyUserData *bud = (BuddyUserData*)pjsua_buddy_get_user_data(id);
+    Account *acc = bud? bud->acc : NULL;
+
+    if (!bud || !acc || !acc->isValid()) {
+        PJSUA2_RAISE_ERROR3(PJ_EINVAL, "sendInstantMessage()",
+                            "Invalid Buddy");
+    }
 
     pj_str_t to = str2Pj(bi.contact.empty()? bi.uri : bi.contact);