Changeset 5934


Ignore:
Timestamp:
Feb 13, 2019 6:51:09 AM (4 months ago)
Author:
nanang
Message:

Re #2176: Removed pop_freelist() + push_freelist() after remove_node() as they are not only unnecessary, they cause problem.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • pjproject/trunk/pjlib/src/pj/timer.c

    r5927 r5934  
    634634        pj_timer_entry *node = remove_node(ht, 0); 
    635635        /* Avoid re-use of this timer until the callback is done. */ 
    636         pj_timer_id_t node_timer_id = pop_freelist(ht); 
     636        ///Not necessary, even causes problem (see also #2176). 
     637        ///pj_timer_id_t node_timer_id = pop_freelist(ht); 
    637638        pj_grp_lock_t *grp_lock; 
    638639 
     
    654655        lock_timer_heap(ht); 
    655656        /* Now, the timer is really free for re-use. */ 
    656         push_freelist(ht, node_timer_id); 
     657        ///push_freelist(ht, node_timer_id); 
    657658    } 
    658659    if (ht->cur_size && next_delay) { 
Note: See TracChangeset for help on using the changeset viewer.