Changeset 5934 for pjproject/trunk/pjlib/src/pj/timer.c

Timestamp:

Feb 13, 2019 6:51:09 AM (5 years ago)

Author:

nanang

Message:

Re #2176: Removed pop_freelist() + push_freelist() after remove_node() as they are not only unnecessary, they cause problem.

File:

• pjproject/trunk/pjlib/src/pj/timer.c (modified) (2 diffs)

pjproject/trunk/pjlib/src/pj/timer.c

@@ -634 +634 @@
         pj_timer_entry *node = remove_node(ht, 0);
         /* Avoid re-use of this timer until the callback is done. */
-        pj_timer_id_t node_timer_id = pop_freelist(ht);
+        ///Not necessary, even causes problem (see also #2176).
+        ///pj_timer_id_t node_timer_id = pop_freelist(ht);
         pj_grp_lock_t *grp_lock;
 
@@ -654 +655 @@
         lock_timer_heap(ht);
         /* Now, the timer is really free for re-use. */
-        push_freelist(ht, node_timer_id);
+        ///push_freelist(ht, node_timer_id);
     }
     if (ht->cur_size && next_delay) {