Changeset 5738 for pjproject/trunk/pjsip-apps/src/swig/java/android/app

Timestamp:

Feb 16, 2018 9:37:00 AM (7 years ago)

Author:

nanang

Message:

Misc (#2059): Update Android & Java app samples to avoid call instance deletion in the library callback context (thanks Kai Ludwig for the feedbacks).

Location:

pjproject/trunk/pjsip-apps/src/swig/java/android/app/src/main/java/org/pjsip/pjsua2/app

Files:

• MainActivity.java (modified) (2 diffs)
• MyApp.java (modified) (1 diff)

pjproject/trunk/pjsip-apps/src/swig/java/android/app/src/main/java/org/pjsip/pjsua2/app/MainActivity.java

@@ -233 +233 @@
         } else if (m.what == MSG_TYPE.CALL_STATE) {
 
-            CallInfo ci = (CallInfo) m.obj;
-
-            /* Forward the message to CallActivity */
-            if (CallActivity.handler_ != null) {
+            MyCall call = (MyCall) m.obj;
+            CallInfo ci;
+            try {
+                ci = call.getInfo();
+            } catch (Exception e) {
+                ci = null;
+            }
+
+            /* Forward the call info to CallActivity */
+            if (ci != null && CallActivity.handler_ != null) {
                 Message m2 = Message.obtain(CallActivity.handler_,
                     MSG_TYPE.CALL_STATE, ci);
                 m2.sendToTarget();
+            }
+
+            if (ci != null &&
+                ci.getState() == pjsip_inv_state.PJSIP_INV_STATE_DISCONNECTED)
+            {
+                call.delete();
             }
 
@@ -602 +614 @@
             ci = null;
         }
-        Message m = Message.obtain(handler, MSG_TYPE.CALL_STATE, ci);
+        Message m = Message.obtain(handler, MSG_TYPE.CALL_STATE, call);
         m.sendToTarget();
 

pjproject/trunk/pjsip-apps/src/swig/java/android/app/src/main/java/org/pjsip/pjsua2/app/MyApp.java

@@ -62 +62 @@
     public void onCallState(OnCallStateParam prm)
     {
-            MyApp.observer.notifyCallState(this);
-            try {
-                CallInfo ci = getInfo();
-                if (ci.getState() == 
-                    pjsip_inv_state.PJSIP_INV_STATE_DISCONNECTED)
-                {
-                    MyApp.ep.utilLogWrite(3, "MyCall", this.dump(true, ""));
-                    this.delete();
-                }
-            } catch (Exception e) {
-                return;
-            }
+        try {
+            CallInfo ci = getInfo();
+            if (ci.getState() == 
+                pjsip_inv_state.PJSIP_INV_STATE_DISCONNECTED)
+            {
+                MyApp.ep.utilLogWrite(3, "MyCall", this.dump(true, ""));
+            }
+        } catch (Exception e) {
+        }
+        
+        // Should not delete this call instance (self) in this context,
+        // so the observer should manage this call instance deletion
+        // out of this callback context.
+        MyApp.observer.notifyCallState(this);
     }