Changeset 5693 for pjproject/trunk/pjlib-util/src/pjlib-util/scanner.c

Timestamp:

Nov 14, 2017 8:20:15 AM (7 years ago)

Author:

ming

Message:

Fixed #2063: Add more documentation in PJSIP's parser to prevent stack buffer overflow

File:

• pjproject/trunk/pjlib-util/src/pjlib-util/scanner.c (modified) (2 diffs)

pjproject/trunk/pjlib-util/src/pjlib-util/scanner.c

@@ -23 +23 @@
 #include <pj/except.h>
 #include <pj/os.h>
+#include <pj/log.h>
 #include <pj/errno.h>
 #include <pj/assert.h>
+
+#define THIS_FILE   "scanner.c"
 
 #define PJ_SCAN_IS_SPACE(c)             ((c)==' ' || (c)=='\t')
@@ -117 +120 @@
 {
     PJ_CHECK_STACK();
+
+    /* Buffer validation. Must be NULL terminated.
+     * See ticket #2063.
+     */
+    pj_assert(*scanner->end == 0);
 
     scanner->begin = scanner->curptr = bufstart;