Changeset 5563 for pjproject/trunk/pjlib/src/pj/guid_android.c

Timestamp:

Mar 7, 2017 3:28:56 AM (8 years ago)

Author:

riza

Message:

Re #1994: Prevent overflow on pj_generate_unique_string() for android.
Thanks to Esed Alihodzic for the report and patch.

File:

• pjproject/trunk/pjlib/src/pj/guid_android.c (modified) (2 diffs)

pjproject/trunk/pjlib/src/pj/guid_android.c

@@ -70 +70 @@
         goto on_error;
 
-    uuid_class = (jclass)(*jni_env)->NewGlobalRef(jni_env,
-                 (*jni_env)->FindClass(jni_env, "java/util/UUID"));
+    uuid_class = (*jni_env)->FindClass(jni_env, "java/util/UUID");
+
     if (uuid_class == 0)
         goto on_error;
@@ -107 +107 @@
 
     (*jni_env)->ReleaseStringUTFChars(jni_env, uuid_string, native_string);
+    (*jni_env)->DeleteLocalRef(jni_env, javaUuid);
+    (*jni_env)->DeleteLocalRef(jni_env, uuid_class);
+    (*jni_env)->DeleteLocalRef(jni_env, uuid_string);
     detach_jvm(attached);