Changeset 5437

Timestamp:

Sep 15, 2016 7:03:37 AM (8 years ago)

Author:

nanang

Message:

Misc (re #1945): Updated resolver behaviour to not mark nameserver as bad after responding with PJ_DNS_RCODE_SERVFAIL. Thanks George Joseph for the feedback and the patch.

File:

• pjproject/trunk/pjlib-util/src/pjlib-util/resolver.c (modified) (1 diff)

pjproject/trunk/pjlib-util/src/pjlib-util/resolver.c

@@ -1385 +1385 @@
     }
 
-    if (!pkt || rcode == PJ_DNS_RCODE_SERVFAIL ||
+    /* Some nameserver is reported to respond with PJ_DNS_RCODE_SERVFAIL for
+     * missing AAAA record, and the standard doesn't seem to specify that
+     * SERVFAIL should prevent the server to be contacted again for other
+     * queries. So let's not mark nameserver as bad for SERVFAIL response.
+     */
+    if (!pkt || /* rcode == PJ_DNS_RCODE_SERVFAIL || */
                 rcode == PJ_DNS_RCODE_REFUSED ||
                 rcode == PJ_DNS_RCODE_NOTAUTH)