Changeset 5373 for pjproject/trunk/pjsip/src/pjsip/sip_auth_client.c

Timestamp:

Jun 30, 2016 8:23:08 AM (8 years ago)

Author:

ming

Message:

Fixed #1929: Fixed memory leak when using sip_auth_client since it's also used by other components, such as sip_dialog, publishc, and pjsua_im.

Application should use the new API pjsip_auth_clt_deinit() to release the pool.

File:

• pjproject/trunk/pjsip/src/pjsip/sip_auth_client.c (modified) (3 diffs)

pjproject/trunk/pjsip/src/pjsip/sip_auth_client.c

@@ -500 +500 @@
 
 
+/* Deinit client session. */
+PJ_DEF(pj_status_t) pjsip_auth_clt_deinit(pjsip_auth_clt_sess *sess)
+{
+    pjsip_cached_auth *auth;
+    
+    PJ_ASSERT_RETURN(sess && sess->endpt, PJ_EINVAL);
+    
+    auth = sess->cached_auth.next;
+    while (auth != &sess->cached_auth) {
+        pjsip_endpt_release_pool(sess->endpt, auth->pool);
+        auth = auth->next;
+    }
+
+    return PJ_SUCCESS;
+}
+
+
 /* Clone session. */
 PJ_DEF(pj_status_t) pjsip_auth_clt_clone( pj_pool_t *pool,
@@ -965 +982 @@
                                        pjsip_cached_auth *auth )
 {
-    pj_pool_t *auth_pool = pjsip_endpt_create_pool(endpt, "regc_auth%p", 1024, 
+    pj_pool_t *auth_pool = pjsip_endpt_create_pool(endpt, "auth_cli%p", 1024, 
                                                    1024);
 
@@ -1164 +1181 @@
             cached_auth = PJ_POOL_ZALLOC_T(sess->pool, pjsip_cached_auth);
             cached_auth->pool = pjsip_endpt_create_pool(sess->endpt,
-                                                        "regc_auth%p",
+                                                        "auth_cli%p",
                                                         1024,
                                                         1024);