Changeset 5373 for pjproject/trunk/pjsip/src/pjsip-ua/sip_reg.c

Timestamp:

Jun 30, 2016 8:23:08 AM (8 years ago)

Author:

ming

Message:

Fixed #1929: Fixed memory leak when using sip_auth_client since it's also used by other components, such as sip_dialog, publishc, and pjsua_im.

Application should use the new API pjsip_auth_clt_deinit() to release the pool.

File:

• pjproject/trunk/pjsip/src/pjsip-ua/sip_reg.c (modified) (2 diffs)

pjproject/trunk/pjsip/src/pjsip-ua/sip_reg.c

@@ -177 +177 @@
         pj_lock_release(regc->lock);
     } else {
-        pjsip_cached_auth *auth = NULL;
         pjsip_tpselector_dec_ref(&regc->tp_sel);
         if (regc->last_transport) {
@@ -192 +191 @@
         regc->lock = NULL;
 
-        auth = regc->auth_sess.cached_auth.next;
-        while (auth != &regc->auth_sess.cached_auth) {
-            pjsip_endpt_release_pool(regc->endpt, auth->pool);
-            auth = auth->next;
-        }
-
+        pjsip_auth_clt_deinit(&regc->auth_sess);
         pjsip_endpt_release_pool(regc->endpt, regc->pool);
     }