Changeset 5241 for pjproject/trunk/pjsip/src/pjsua-lib/pjsua_pres.c

Timestamp:

Feb 5, 2016 4:29:17 AM (8 years ago)

Author:

nanang

Message:

Fixed #1902:

• Crash when endpoint has multiple worker threads and SIP TCP transport is disconnected during incoming call handling.
• Deprecated pjsip_dlg_create_uas(), replaced by pjsip_dlg_create_uas_and_inc_lock().
• Serialized transaction state notifications (of 'terminated' and 'destroyed') in case of transport error.

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_pres.c (modified) (3 diffs)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_pres.c

@@ -856 +856 @@
 
     /* Create UAS dialog: */
-    status = pjsip_dlg_create_uas(pjsip_ua_instance(), rdata, 
-                                  &contact, &dlg);
+    status = pjsip_dlg_create_uas_and_inc_lock(pjsip_ua_instance(), rdata,
+                                               &contact, &dlg);
     if (status != PJ_SUCCESS) {
         pjsua_perror(THIS_FILE, 
@@ -922 +922 @@
         }
 
+        pjsip_dlg_dec_lock(dlg);
         PJSUA_UNLOCK();
         pj_log_pop_indent();
         return PJ_TRUE;
     }
+
+    /* Subscription has been created, decrement & release dlg lock */
+    pjsip_dlg_dec_lock(dlg);
 
     /* If account is locked to specific transport, then lock dialog
@@ -1036 +1040 @@
 
     /* Done: */
-
     PJSUA_UNLOCK();
     pj_log_pop_indent();