Changeset 5241 for pjproject/trunk/pjsip-apps/src/samples/simpleua.c

Timestamp:

Feb 5, 2016 4:29:17 AM (8 years ago)

Author:

nanang

Message:

Fixed #1902:

• Crash when endpoint has multiple worker threads and SIP TCP transport is disconnected during incoming call handling.
• Deprecated pjsip_dlg_create_uas(), replaced by pjsip_dlg_create_uas_and_inc_lock().
• Serialized transaction state notifications (of 'terminated' and 'destroyed') in case of transport error.

File:

• pjproject/trunk/pjsip-apps/src/samples/simpleua.c (modified) (3 diffs)

pjproject/trunk/pjsip-apps/src/samples/simpleua.c

@@ -726 +726 @@
      * Create UAS dialog.
      */
-    status = pjsip_dlg_create_uas( pjsip_ua_instance(), 
-                                   rdata,
-                                   &local_uri, /* contact */
-                                   &dlg);
+    status = pjsip_dlg_create_uas_and_inc_lock( pjsip_ua_instance(),
+                                                rdata,
+                                                &local_uri, /* contact */
+                                                &dlg);
     if (status != PJ_SUCCESS) {
         pjsip_endpt_respond_stateless(g_endpt, rdata, 500, NULL,
@@ -742 +742 @@
     status = pjmedia_endpt_create_sdp( g_med_endpt, rdata->tp_info.pool,
                                        MAX_MEDIA_CNT, g_sock_info, &local_sdp);
-    PJ_ASSERT_RETURN(status == PJ_SUCCESS, PJ_TRUE);
+    pj_assert(status == PJ_SUCCESS);
+    if (status != PJ_SUCCESS) {
+        pjsip_dlg_dec_lock(dlg);
+        return PJ_TRUE;
+    }
 
 
@@ -750 +754 @@
      */
     status = pjsip_inv_create_uas( dlg, rdata, local_sdp, 0, &g_inv);
-    PJ_ASSERT_RETURN(status == PJ_SUCCESS, PJ_TRUE);
+    pj_assert(status == PJ_SUCCESS);
+    if (status != PJ_SUCCESS) {
+        pjsip_dlg_dec_lock(dlg);
+        return PJ_TRUE;
+    }
+
+    /*
+     * Invite session has been created, decrement & release dialog lock.
+     */
+    pjsip_dlg_dec_lock(dlg);