Changeset 5221 for pjproject/trunk

Timestamp:

Dec 30, 2015 3:44:12 AM (9 years ago)

Author:

ming

Message:

Re #1882 (misc): Fixed potential out-of-bound array access in ice_session.

Thanks to Dusan Klinec for the patch.

File:

• pjproject/trunk/pjnath/src/pjnath/ice_session.c (modified) (2 diffs)

pjproject/trunk/pjnath/src/pjnath/ice_session.c

@@ -1662 +1662 @@
             pj_ice_sess_cand *lcand = &ice->lcand[i];
             pj_ice_sess_cand *rcand = &ice->rcand[j];
-            pj_ice_sess_check *chk = &clist->checks[clist->count];
+            pj_ice_sess_check *chk = NULL;
 
             if (clist->count >= PJ_ICE_MAX_CHECKS) {
@@ -1668 +1668 @@
                 return PJ_ETOOMANY;
             } 
+
+           chk = &clist->checks[clist->count];
 
             /* A local candidate is paired with a remote candidate if