Changeset 4983 for pjproject/trunk/pjnath/src/pjnath/stun_session.c

Timestamp:

Feb 13, 2015 11:34:26 AM (9 years ago)

Author:

ming

Message:

Fixed #1815: Race condition of STUN transaction destruction

File:

• pjproject/trunk/pjnath/src/pjnath/stun_session.c (modified) (1 diff)

pjproject/trunk/pjnath/src/pjnath/stun_session.c

@@ -150 +150 @@
     pj_stun_client_tsx_stop(tsx);
     if (tdata) {
-        tsx_erase(tdata->sess, tdata);
+        pj_stun_session *sess = tdata->sess;
+        
+        pj_grp_lock_acquire(sess->grp_lock);
+        tsx_erase(sess, tdata);
         pj_pool_release(tdata->pool);
-    }
+        pj_grp_lock_release(sess->grp_lock);
+    }
+
+    pj_stun_client_tsx_destroy(tsx);
 
     TRACE_((THIS_FILE, "STUN transaction %p destroyed", tsx));