Changeset 4876


Ignore:
Timestamp:
Jul 14, 2014 4:49:25 AM (7 years ago)
Author:
nanang
Message:

Misc (re #1751): Fixed possible bad assertion caused by race condition between regc_tsx_callback() and pjsip_regc_send() (thanks John Ryan for the report).

File:
1 edited

Legend:

Unmodified
Added
Removed
  • pjproject/trunk/pjsip/src/pjsip-ua/sip_reg.c

    r4586 r4876  
    13631363    } 
    13641364 
    1365     pj_assert(regc->current_op == REGC_IDLE); 
     1365    /* Just regc->has_tsx check above should be enough. This assertion check 
     1366     * may cause problem, e.g: when regc_tsx_callback() invokes callback, 
     1367     * lock is released and 'has_tsx' is set to FALSE and 'current_op' has 
     1368     * not been updated to REGC_IDLE yet. 
     1369     */ 
     1370    //pj_assert(regc->current_op == REGC_IDLE); 
    13661371 
    13671372    /* Invalidate message buffer. */ 
Note: See TracChangeset for help on using the changeset viewer.