Changeset 4613 for pjproject/trunk/pjsip/src/pjsua-lib/pjsua_acc.c

Timestamp:

Oct 8, 2013 9:08:13 AM (11 years ago)

Author:

bennylp

Message:

Re #1703: fixing general bugs. First installment: correct handling of snprintf return value

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_acc.c (modified) (3 diffs)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_acc.c

@@ -1750 +1750 @@
                                (int)acc->cfg.contact_params.slen,
                                acc->cfg.contact_params.ptr);
-        if (len < 1) {
+        if (len < 1 || len >= PJSIP_MAX_URL_SIZE) {
             PJ_LOG(1,(THIS_FILE, "URI too long"));
             pj_pool_release(pool);
@@ -3102 +3102 @@
                                      (int)acc->cfg.contact_params.slen,
                                      acc->cfg.contact_params.ptr);
-
+    if (contact->slen < 1 || contact->slen >= (int)PJSIP_MAX_URL_SIZE)
+        return PJ_ETOOSMALL;
     return PJ_SUCCESS;
 }
@@ -3272 +3273 @@
                                      (int)acc->cfg.contact_params.slen,
                                      acc->cfg.contact_params.ptr);
+    if (contact->slen < 1 || contact->slen >= (int)PJSIP_MAX_URL_SIZE)
+        return PJ_ETOOSMALL;
 
     return PJ_SUCCESS;