Changeset 4413 for pjproject/trunk/pjnath/src/pjnath/stun_transaction.c

Timestamp:

Mar 5, 2013 6:29:15 AM (11 years ago)

Author:

ming

Message:

Re #1616: Fixed assertion trying to release group lock when STUN transaction is already destroyed in the callback

File:

• pjproject/trunk/pjnath/src/pjnath/stun_transaction.c (modified) (2 diffs)

pjproject/trunk/pjnath/src/pjnath/stun_transaction.c

@@ -343 +343 @@
 
     if (tsx->transmit_count >= PJ_STUN_MAX_TRANSMIT_COUNT) {
+        /* tsx may be destroyed when calling the callback below */
+        pj_grp_lock_t *grp_lock = tsx->grp_lock;
+
         /* Retransmission count exceeded. Transaction has failed */
         tsx->retransmit_timer.id = 0;
@@ -353 +356 @@
             }
         }
-        pj_grp_lock_release(tsx->grp_lock);
+        pj_grp_lock_release(grp_lock);
         /* We might have been destroyed, don't try to access the object */
         pj_log_pop_indent();